Skip to content

gh-127906: Add missing sys import to test_cppext - #132902

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:test_cppext
Apr 25, 2025
Merged

gh-127906: Add missing sys import to test_cppext#132902
vstinner merged 1 commit into
python:mainfrom
vstinner:test_cppext

Conversation

@vstinner

@vstinnervstinner commented Apr 25, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Apr 25, 2025
Closed
@AA-Turner

AA-Turner commented Apr 25, 2025

Copy link
Copy Markdown
Member

I opened #132903 at the same time!

@vstinner

vstinner commented Apr 25, 2025

Copy link
Copy Markdown
MemberAuthor

It's unclear to me how the code worked before without the sys import.

I opened #132903 at the same time!

4 minutes after me, that's fun :-D I prefer to attach the change to #127906 which introduced the code. The setuptools update is just the trigger to spot the bug.

@vstinner
vstinner merged commit 9cba148 into python:mainApr 25, 2025
@vstinner
vstinner deleted the test_cppext branch April 25, 2025 08:19
@miss-islington-app

miss-islington-appBot commented Apr 25, 2025

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 25, 2025
@vstinner@miss-islington
pythongh-127906: Add missing sys import to test_cppext (pythonGH-132902)
af50cc3
(cherry picked from commit 9cba148)
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-appBot commented Apr 25, 2025

Copy link
Copy Markdown

GH-132904 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Apr 25, 2025
@vstinnervstinner added the needs backport to 3.12 only security fixes label Apr 25, 2025
@miss-islington-app

miss-islington-appBot commented Apr 25, 2025

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 25, 2025
@vstinner@miss-islington
pythongh-127906: Add missing sys import to test_cppext (pythonGH-132902)
0cc6f61
(cherry picked from commit 9cba148)
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-appBot commented Apr 25, 2025

Copy link
Copy Markdown

GH-132905 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Apr 25, 2025
This was referenced Apr 25, 2025
Closed
Closed
@hugovkhugovk mentioned this pull request Apr 25, 2025
Closed
vstinner added a commit that referenced this pull request Apr 25, 2025
@miss-islington@vstinner
[3.13]gh-127906: Add missing sys import to test_cppext (GH-132902) (#…
8a759c2
…132904)
gh-127906: Add missing sys import to test_cppext (GH-132902)
(cherry picked from commit 9cba148)
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@AA-Turner