gh-132908: Add math.isnormal/issubnormal() functions by skirpichev · Pull Request #132935 · python/cpython

skirpichev · 2025-04-25T13:15:30Z

Issue: Have math.isnormal() and, perhaps, math.issubnormal()? #132908

📚 Documentation preview 📚: https://cpython-previews--132935.org.readthedocs.build/

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

picnixz

Just some cosmetic nits.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz · 2025-04-25T14:55:37Z

So, we have some known buildbots issues. I'll wait for it to be solved and then once it's ok for them, I'll merge it.

skirpichev · 2025-04-25T15:12:38Z

Technically it's very trivial pr, yet I would appreciate a second look from someone.

Maybe we should be more vague and not define in any way normal/subnormal meaning (i.e. not reference sys.float_info). (Or mention this as CPython implementation detail.) E.g. should all Python implementations support subnormals?

StanFromIreland

IMO the docs and implementation are fine, everything is explained well.

skirpichev

Maybe we can replace "floating-point number" with just a "number" (as integers are automatically converted to floats)?

skirpichev · 2025-06-02T06:47:00Z

CC @serhiy-storchaka per experts index. See also issue thread.

serhiy-storchaka

LGTM. 👍

pythongh-132908: add math.normal/subnormal() functions
9d14505

bedevere-appBot added the awaiting review label Apr 25, 2025

bedevere-appBot mentioned this pull request Apr 25, 2025
Have math.isnormal() and, perhaps, math.issubnormal()? #132908
Closed

oops, test name
7350b25

StanFromIreland reviewed Apr 25, 2025
View reviewed changes

Comment threadDoc/library/math.rst Outdated
Comment threadDoc/library/math.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadMisc/NEWS.d/next/Library/2025-04-25-16-06-53.gh-issue-132908.wV5rja.rst Outdated
Comment threadDoc/library/math.rst

skirpichev commented Apr 25, 2025
View reviewed changes

Comment threadMisc/NEWS.d/next/Library/2025-04-25-16-06-53.gh-issue-132908.wV5rja.rst Outdated

skirpichev commented Apr 25, 2025
View reviewed changes

Comment threadDoc/library/math.rst Outdated

skirpichev commented Apr 25, 2025
View reviewed changes

Comment threadDoc/library/math.rst Outdated

Apply suggestions from code review
4eb3669
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

picnixz approved these changes Apr 25, 2025
View reviewed changes

Comment threadDoc/library/math.rst Outdated
Comment threadDoc/library/math.rst Outdated
Comment threadModules/mathmodule.c Outdated
Comment threadModules/mathmodule.c
Comment threadModules/mathmodule.c
Comment threadModules/mathmodule.c

bedevere-appBot added awaiting merge and removed awaiting review labels Apr 25, 2025

skirpichevand others added 2 commits April 25, 2025 17:45

Apply suggestions from code review
37b3345
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Apply suggestions from code review
e318087
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

StanFromIreland approved these changes Apr 25, 2025
View reviewed changes

skirpichev commented Apr 28, 2025
View reviewed changes

Comment threadDoc/library/math.rst Outdated
Comment threadDoc/library/math.rst Outdated
Comment threadDoc/library/math.rst Outdated

skirpichev added 3 commits May 8, 2025 15:26

Merge branch 'master' into isnormal-subnormal/132908
a8431f7

-> 3.15
dc88e9e

Merge branch 'master' into isnormal-subnormal/132908
0503090

skirpichev requested a review from serhiy-storchaka June 2, 2025 06:35

serhiy-storchaka changed the title ~~gh-132908: add math.normal/subnormal() functions~~gh-132908: Add math.isnormal/issubnormal() functionsJun 2, 2025

serhiy-storchaka approved these changes Jun 2, 2025
View reviewed changes

Comment threadModules/mathmodule.c Outdated
Comment threadDoc/library/math.rst Outdated

skirpichev added 2 commits June 2, 2025 11:19

Apply suggestions from code review
066e884

address review: remove (long) casts
08f81f5

serhiy-storchaka merged commit 5f61cde into python:mainJun 2, 2025

bedevere-appBot removed the awaiting merge label Jun 2, 2025

skirpichev deleted the isnormal-subnormal/132908 branch June 2, 2025 10:47

Uh oh!

Uh oh!

Conversation

skirpichev commented Apr 25, 2025• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz commented Apr 25, 2025

Uh oh!

skirpichev commented Apr 25, 2025

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

skirpichev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skirpichev commented Jun 2, 2025

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

skirpichev commented Apr 25, 2025•
edited by github-actions Bot
Loading

skirpichev left a comment •
edited
Loading