Uh oh!
There was an error while loading. Please reload this page.
bpo-30535: Explicitly note that sys.meta_path is not empty - #13300
bpo-30535: Explicitly note that sys.meta_path is not empty#13300Windsooon wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
This is not grammatically correct: a sentence should start with a capital letter and contain a verb.
There was a problem hiding this comment.
Thank you, how about
"By default, it holds entries to handle the standard kinds of modules (.py files, extension modules...)."
brettcannon
left a comment
There was a problem hiding this comment.
Technically there aren't different kinds of modules, just different ways of storing code. I have suggested a tweak to the wording.
| :meth:`~importlib.abc.MetaPathFinder.find_spec` methods called to see if one | ||
| of the objects can find the module to be imported. The | ||
| of the objects can find the module to be imported. By default, it holds entries | ||
| to handle the standard kinds of modules (.py files, extension modules...). The |
There was a problem hiding this comment.
| to handle the standard kinds of modules (.py files, extension modules...). The | |
| that implement Python's default import semantics. The |
There was a problem hiding this comment.
@brettcannon Do you think we should add examples after that. Like:
that implement Python's default import semantics. (BuiltinImporter, FrozenImporter, and PathFinder)
There was a problem hiding this comment.
No, as that's too easy of a thing to forget to update. Plus there's no guarantee that every interpreter will set up sys.meta_path the same.
bedevere-bot
commented
May 27, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
brettcannon
left a comment
There was a problem hiding this comment.
I don't think the docs should get too specific as interpreters can choose what to put into sys.meta_path.
csabella
commented
Jan 26, 2020
@Windsooon, please take a look at the review comments. Thanks! |
AlexWaygood
commented
Apr 19, 2022
Changes were requested by a core dev over two years ago, but have not been made. I am therefore closing this PR. @Windsooon, if you're still interested in working on this, feel free to open a new PR. Alternatively, ping me, and I'll happily reopen this PR. Thanks! 🙂 |
iritkatriel
commented
Jun 21, 2022
I tried to updated this PR with Brett's comment but I don't think I can. I will create a new PR. |
Explicitly note that sys.meta_path is not empty
https://bugs.python.org/issue30535