Skip to content

gh-132983: Convert compression._common to a package - #133086

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:fix_freeze
Apr 28, 2025
Merged

gh-132983: Convert compression._common to a package#133086
vstinner merged 1 commit into
python:mainfrom
vstinner:fix_freeze

Conversation

@vstinner

@vstinnervstinner commented Apr 28, 2025

Copy link
Copy Markdown
Member

Add an __init__ file. Fix test_tools.test_freeze.

Add an __init__ file. Fix test_tools.test_freeze.
@vstinner

Copy link
Copy Markdown
MemberAuthor

@emmatypingemmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@picnixz

Copy link
Copy Markdown
Member

I'll close #133076 then

@emmatyping

Copy link
Copy Markdown
Member

Should we also consider the module finder error a bug? Perhaps it would be good to file an issue for it?

@vstinner
vstinner merged commit fe8ad53 into python:mainApr 28, 2025
@vstinner
vstinner deleted the fix_freeze branch April 28, 2025 14:13
@vstinner

Copy link
Copy Markdown
MemberAuthor

Should we also consider the module finder error a bug? Perhaps it would be good to file an issue for it?

Honestly, I don't know. I just wrote a change to fix buildbots :-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@picnixz@emmatyping@JelleZijlstra