Skip to content

gh-87135: test_threading: Wait on thread, not an Event it sets - #133198

Merged
encukou merged 1 commit into
python:mainfrom
encukou:test_join_finished_daemon_thread_in_finalization
Apr 30, 2025
Merged

gh-87135: test_threading: Wait on thread, not an Event it sets#133198
encukou merged 1 commit into
python:mainfrom
encukou:test_join_finished_daemon_thread_in_finalization

Conversation

@encukou

@encukouencukou commented Apr 30, 2025

Copy link
Copy Markdown
Member

Sorry for this mistake!
When the event is set the thread might not be done yet. This should fix newly-flaky refleak buildbots.

This is a fix-up for commit 4ebbfcf

When the event is set the thread might not be done yet.
This is a fix-up for commit 4ebbfcf

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou
encukou merged commit 8b26b23 into python:mainApr 30, 2025
@encukou
encukou deleted the test_join_finished_daemon_thread_in_finalization branch April 30, 2025 13:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@encukou@vstinner