Skip to content

GH-133231: Add JIT utilities in sys._jit - #133233

Merged
brandtbucher merged 17 commits into
python:mainfrom
brandtbucher:sys-jit
May 5, 2025
Merged

GH-133231: Add JIT utilities in sys._jit#133233
brandtbucher merged 17 commits into
python:mainfrom
brandtbucher:sys-jit

Conversation

@brandtbucher

@brandtbucherbrandtbucher commented May 1, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@brandtbucherbrandtbucher added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT labels May 1, 2025
@brandtbucherbrandtbucher self-assigned this May 1, 2025
@bedevere-appbedevere-appBot mentioned this pull request May 1, 2025
Closed
AA-Turner
AA-Turner reviewed May 1, 2025
View reviewed changes

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick doc-only review:

Comment threadDoc/library/sys.rst Outdated
Comment threadDoc/library/sys.rst Outdated
Comment threadDoc/library/sys.rst
Comment threadDoc/using/cmdline.rst
Comment on lines +1284 to +1290
.. envvar:: PYTHON_JIT

On builds where experimental just-in-time compilation is available, this
variable can force the JIT to be disabled (``0``) or enabled (``1``) at
interpreter startup.

.. versionadded:: 3.13

@AA-TurnerAA-TurnerMay 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should backport this, should it be split out into a different PR for ease?

@brandtbucherbrandtbucherMay 1, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just backport it separately, since I need the ref for this PR's changes.

@AA-TurnerAA-TurnerMay 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth using miss-islington for the backport here?

@brandtbucherbrandtbucherMay 6, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just do it manually in a bit.

@brandtbucher

brandtbucher commented May 1, 2025

Copy link
Copy Markdown
MemberAuthor

I just realized that my approach for sys._jit.is_active() will need reworking, since the tail-calling interpreter doesn't have entry_frame handy.

@brandtbucher

brandtbucher commented May 1, 2025

Copy link
Copy Markdown
MemberAuthor

Okay, reworked to support tail-calling.

@brandtbucher

brandtbucher commented May 2, 2025

Copy link
Copy Markdown
MemberAuthor

@markshannon, let me know what you think. The bots won't let us merge features without approving review, but I'd like to get something like this in before the freeze.

markshannon
markshannon reviewed May 5, 2025
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
One small suggestion

Comment threadLib/test/test_sys.py Outdated
@brandtbucher
brandtbucher merged commit b1aa515 into python:mainMay 5, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@brandtbucher@Pranjal095
pythonGH-133231: Add JIT utilities in sys._jit (pythonGH-133233)
aeb8e07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments
@markshannonmarkshannonmarkshannon approved these changes
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

@brandtbucherbrandtbucher

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-JITtype-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brandtbucher@AA-Turner@markshannon