gh-132775: Unrevert "Add _PyCode_GetVarCounts()" by ericsnowcurrently · Pull Request #133265 · python/cpython

ericsnowcurrently · 2025-05-01T16:27:35Z

This reverts commit 811edcf (gh-133128).

We reverted that change due to failing s390 builds (a big-endian architecture).

(This PR will be the fix, but I'm also using it to diagnose the problem and iterate on the solution, so I can run against the s390 buildbots.)

Issue: Improvements to test.support.interpreters.Interpreter #132775

This reverts commit 811edcf (pythongh-133128).

ericsnowcurrently · 2025-05-01T17:30:33Z

!buildbot s390x RHEL8 LTO

bedevere-bot · 2025-05-01T17:30:36Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 54b6192 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR

ericsnowcurrently · 2025-05-01T19:59:07Z

!buildbot s390x RHEL8 LTO

bedevere-bot · 2025-05-01T19:59:10Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5f6fe84 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR

ericsnowcurrently · 2025-05-02T02:36:07Z

!buildbot s390x RHEL8 LTO

bedevere-bot · 2025-05-02T02:36:10Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 39692ea 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR

ericsnowcurrently · 2025-05-02T02:52:02Z

!buildbot s390x RHEL8 LTO

bedevere-bot · 2025-05-02T02:52:06Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 8c83a94 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR

ericsnowcurrently · 2025-05-02T03:10:26Z

!buildbot s390x RHEL8 LTO

bedevere-bot · 2025-05-02T03:10:28Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 01bb302 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR

ericsnowcurrently · 2025-05-02T04:47:21Z

!buildbot s390x RHEL8 LTO + PGO

bedevere-bot · 2025-05-02T04:47:24Z

The regex 's390x RHEL8 LTO + PGO' did not match any buildbot builder. Is the requested builder in the list of stable builders?

ericsnowcurrently · 2025-05-02T04:47:36Z

!buildbot s390x RHEL8 LTO

bedevere-bot · 2025-05-02T04:47:39Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 01bb302 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR

ericsnowcurrently · 2025-05-02T06:20:20Z

!buildbot s390x RHEL8 LTO

bedevere-bot · 2025-05-02T06:20:24Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 97677cb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR

ericsnowcurrently · 2025-05-03T05:14:17Z

!buildbot s390x RHEL8 LTO

bedevere-bot · 2025-05-03T05:14:20Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 170c354 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR

ericsnowcurrently · 2025-05-03T16:01:25Z

!buildbot s390x RHEL8 LTO

bedevere-bot · 2025-05-03T16:01:28Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0128404 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR

ericsnowcurrently · 2025-05-03T19:45:32Z

!buildbot s390x RHEL8 LTO + PGO

bedevere-bot · 2025-05-03T19:45:35Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 4fa2ecf 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO \+ PGO

The builders matched are:

s390x RHEL8 LTO + PGO PR

ericsnowcurrently · 2025-05-03T23:33:32Z

!buildbot s390x RHEL8 LTO + PGO

bedevere-bot · 2025-05-03T23:33:35Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 4347b13 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO \+ PGO

The builders matched are:

s390x RHEL8 LTO + PGO PR

ericsnowcurrently · 2025-05-04T00:28:56Z

!buildbot s390x RHEL8 LTO + PGO

bedevere-bot · 2025-05-04T00:28:59Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit c199564 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO \+ PGO

The builders matched are:

s390x RHEL8 LTO + PGO PR

ericsnowcurrently · 2025-05-05T16:03:53Z

!buildbot s390x RHEL8 LTO + PGO

bedevere-bot · 2025-05-05T16:03:56Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit c8877e4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO \+ PGO

The builders matched are:

s390x RHEL8 LTO + PGO PR

This reverts commit 811edcf (pythongh-133232), which itself reverted the original commit 811edcf (pythongh-133128). We reverted the original change due to failing s390 builds (a big-endian architecture). It ended up that I had not accommodated op caches.

ericsnowcurrently added 2 commits May 1, 2025 10:09

pythongh-132775: Unrevert "Add _PyCode_GetVarCounts()"
d9c3672
This reverts commit 811edcf (pythongh-133128).

Avoid casting to int.
54b6192

ericsnowcurrently added the skip news label May 1, 2025

bedevere-appBot mentioned this pull request May 1, 2025
Improvements to test.support.interpreters.Interpreter #132775
Closed

ericsnowcurrently added 5 commits May 1, 2025 11:45

Cast to int.
b97326f

Add an assert.
1e6aa82

Add some helper macros.
881c798

Track counts using a local variable.
ae1efb3

Do not double-count names.
5f6fe84

ericsnowcurrently force-pushed the unrevert-add-pycode-get-var-counts branch from 39692ea to 8c83a94Compare May 2, 2025 02:51

ericsnowcurrently force-pushed the unrevert-add-pycode-get-var-counts branch from 8c83a94 to 01bb302Compare May 2, 2025 03:09

ericsnowcurrently force-pushed the unrevert-add-pycode-get-var-counts branch from 01bb302 to 97677cbCompare May 2, 2025 06:18

ambv mentioned this pull request May 2, 2025
gh-131507: Add support for syntax highlighting in PyREPL #133247
Merged

Temporarily skip some code.
c9855f1

Temporarily skip some code.
170c354

Temporarily skip some code.
0128404

Temporarily skip some code.
4fa2ecf

Print the ind=ex.
4347b13

Print more stuff.
c199564

ericsnowcurrently added 2 commits May 5, 2025 09:37

Drop the temporary code.
88f7beb

Respect op caches.
c8877e4

Add a critical section.
5b3c975

ericsnowcurrently marked this pull request as ready for review May 5, 2025 18:46

ericsnowcurrently requested a review from markshannon as a code owner May 5, 2025 18:46

bedevere-appBot added the awaiting core review label May 5, 2025

ericsnowcurrently removed the request for review from markshannon May 5, 2025 18:46

ericsnowcurrently force-pushed the unrevert-add-pycode-get-var-counts branch from ec03cf0 to 5b3c975Compare May 5, 2025 18:47

ericsnowcurrently merged commit 24ebb9c into python:mainMay 5, 2025

bedevere-appBot removed the awaiting core review label May 5, 2025

ericsnowcurrently deleted the unrevert-add-pycode-get-var-counts branch May 5, 2025 19:24

sobolevn mentioned this pull request May 11, 2025
Missing error handling in SET_COUNT macro in _testinternalcapi.c#133891
Closed

Uh oh!

Uh oh!

Conversation

ericsnowcurrently commented May 1, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericsnowcurrently commented May 1, 2025

Uh oh!

bedevere-bot commented May 1, 2025

Uh oh!

ericsnowcurrently commented May 1, 2025

Uh oh!

bedevere-bot commented May 1, 2025

Uh oh!

ericsnowcurrently commented May 2, 2025

Uh oh!

bedevere-bot commented May 2, 2025

Uh oh!

ericsnowcurrently commented May 2, 2025

Uh oh!

bedevere-bot commented May 2, 2025

Uh oh!

ericsnowcurrently commented May 2, 2025

Uh oh!

bedevere-bot commented May 2, 2025

Uh oh!

ericsnowcurrently commented May 2, 2025

Uh oh!

bedevere-bot commented May 2, 2025

Uh oh!

ericsnowcurrently commented May 2, 2025

Uh oh!

bedevere-bot commented May 2, 2025

Uh oh!

ericsnowcurrently commented May 2, 2025

Uh oh!

bedevere-bot commented May 2, 2025

Uh oh!

ericsnowcurrently commented May 3, 2025

Uh oh!

bedevere-bot commented May 3, 2025

Uh oh!

ericsnowcurrently commented May 3, 2025

Uh oh!

bedevere-bot commented May 3, 2025

Uh oh!

ericsnowcurrently commented May 3, 2025

Uh oh!

bedevere-bot commented May 3, 2025

Uh oh!

ericsnowcurrently commented May 3, 2025

Uh oh!

bedevere-bot commented May 3, 2025

Uh oh!

ericsnowcurrently commented May 4, 2025

Uh oh!

bedevere-bot commented May 4, 2025

Uh oh!

ericsnowcurrently commented May 5, 2025

Uh oh!

bedevere-bot commented May 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ericsnowcurrently commented May 1, 2025•
edited
Loading