Uh oh!
There was an error while loading. Please reload this page.
gh-133194: Fix regression with PEP 758 parsing on older feature_version - #133289
Merged
Conversation
feature_versionfeature_versionlysnikolaou
approved these changes
May 2, 2025
lysnikolaou
left a comment
Member
There was a problem hiding this comment.
Yeah, this looks good to me! Missed it in the earlier PR. Surprised that the tests didn't catch it.
sobolevn
commented
May 2, 2025
MemberAuthor
I will keep this open for a day, so maybe @pablogsal can also comment. Thanks everyone 👍 |
Eclips4
approved these changes
May 2, 2025
Pranjal095 pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…e_version` (python#133289) pythongh-133192: Fix regression with PEP 758 parsing on older `feature_version`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous change was not quite correct in two ways:
except TypeError:with olderfeature_versions :(I added a lot more tests and fixed the problem (hopefully)! Reviews are highly appreciated 🙏
Fixes#133195
Fixes#133194
cc @cdce8p
CHECK_VERSIONguard for usage withast.parse(..., feature_version=(3, 13))#133194