Skip to content

Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)" - #13329

Closed
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:revert_asyncio
Closed

Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"#13329
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:revert_asyncio

Conversation

@vstinner

@vstinnervstinner commented May 14, 2019

Copy link
Copy Markdown
Member

@vstinner

Copy link
Copy Markdown
MemberAuthor

I already reverted the change in 3.7: PR #13328.

The revert in master is motivated by https://bugs.python.org/issue36870 : test_asyncio fails randomly which causes a lot of pain in the Python CI and the Python workflow.

I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870

@asvetlov

Copy link
Copy Markdown
Contributor

I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870

I guess no, the PR #13313 doesn't fix your issue.
This pull request is necessary (but please don't revert #13313 and #13099)

@asvetlov

Copy link
Copy Markdown
Contributor

#13330 is a minimal change that reverts StreamWriter.drain() on the master to code that was working properly.
I suggest to use it instead, tests should pass

@vstinner

Copy link
Copy Markdown
MemberAuthor

I suggest to use it instead, tests should pass

Honestly, I don't care: it's up to you, as soon as test_asyncio pass: as soon as https://bugs.python.org/issue36870 is fixed.

@vstinner

Copy link
Copy Markdown
MemberAuthor

@asvetlov merged PR #13330 instead. I close this PR.

@vstinner
vstinner deleted the revert_asyncio branch May 14, 2019 21:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@asvetlov@the-knights-who-say-ni@bedevere-bot