Skip to content

gh-131178: Add tests for ast command-line interface - #133329

Merged
sobolevn merged 11 commits into
python:mainfrom
donbarbos:issue-131178-ast
May 4, 2025
Merged

gh-131178: Add tests for ast command-line interface#133329
sobolevn merged 11 commits into
python:mainfrom
donbarbos:issue-131178-ast

Conversation

@donbarbos

@donbarbosdonbarbos commented May 3, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request May 3, 2025
Open
9 tasks
@Eclips4Eclips4 self-assigned this May 3, 2025
StanFromIreland
StanFromIreland reviewed May 3, 2025
View reviewed changes
Comment threadLib/test/test_ast/test_ast.py
tomasr8
tomasr8 reviewed May 3, 2025
View reviewed changes
Comment threadLib/test/test_ast/test_ast.py
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Eclips4
Eclips4 approved these changes May 4, 2025
View reviewed changes

@Eclips4Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

sobolevn
sobolevn reviewed May 4, 2025
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also test that -h and --help works.

Comment threadLib/ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py
Comment threadLib/test/test_ast/test_ast.py
sobolevn
sobolevn reviewed May 4, 2025
View reviewed changes
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
@skirpichevskirpichev mentioned this pull request May 4, 2025
Merged
JelleZijlstra
JelleZijlstra reviewed May 4, 2025
View reviewed changes
Comment threadLib/test/test_ast/test_ast.py Outdated
sobolevn
sobolevn reviewed May 4, 2025
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor things :)

Comment threadLib/test/test_ast/test_ast.py Outdated
Comment threadLib/test/test_ast/test_ast.py Outdated
donbarbosand others added 2 commits May 5, 2025 00:45
@donbarbos
Update test_ast.py
9f6f5b2
@donbarbos@sobolevn
Update test_ast.py
361706a
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn
sobolevn approved these changes May 4, 2025
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@sobolevn
sobolevn enabled auto-merge (squash) May 4, 2025 20:56
@donbarbos

donbarbos commented May 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Thank you everyone

@sobolevn
sobolevn merged commit 6ce60f1 into python:mainMay 4, 2025
diegorusso added a commit to diegorusso/cpython that referenced this pull request May 4, 2025
@diegorusso
Merge remote-tracking branch 'origin/main' into call-len
c03babc
* origin/main: (111 commits)
pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)
pythongh-131178: Add tests for `ast` command-line interface (python#133329)
Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)
pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)
pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)
pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)
pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)
pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)
pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)
pythongh-132457: make staticmethod and classmethod generic (python#132460)
pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)
pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)
pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)
pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)
pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)
bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)
pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)
pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)
pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)
pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)
...
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@donbarbos@sobolevn@Pranjal095
pythongh-131178: Add tests forastcommand-line interface (python#1…
d7c8dbe
…33329)
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments
@tomasr8tomasr8tomasr8 left review comments
@Eclips4Eclips4Eclips4 approved these changes
@StanFromIrelandStanFromIrelandStanFromIreland left review comments
@sobolevnsobolevnsobolevn approved these changes
@isidenticalisidenticalAwaiting requested review from isidenticalisidentical is a code owner

Assignees

@Eclips4Eclips4

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@donbarbos@JelleZijlstra@sobolevn@tomasr8@Eclips4@StanFromIreland