gh-131798: JIT: Narrow the return type of `_GET_LEN` to int by Zheaoli · Pull Request #133345 · python/cpython

Zheaoli · 2025-05-03T14:32:49Z

Signed-off-by: Manjusaka me@manjusaka.me

Issue: Better uop coverage in the JIT optimizer #131798

bedevere-app · 2025-05-06T20:18:41Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli · 2025-05-08T07:46:41Z

I have made the requested changes; please review again.

bedevere-app · 2025-05-08T07:46:47Z

Thanks for making the requested changes!

@Fidget-Spinner, @brandtbucher: please review the changes made to this pull request.

Zheaoli · 2025-05-08T07:47:33Z

BTW @brandtbucher @Fidget-Spinner sorry about the force push. I set pull with rebase as default on my environment. I will modify it in next PR(

bedevere-app · 2025-05-08T19:27:32Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli · 2025-05-20T20:21:09Z

I have made the requested changes; please review again

bedevere-app · 2025-05-20T20:21:17Z

Thanks for making the requested changes!

@Fidget-Spinner, @brandtbucher: please review the changes made to this pull request.

Signed-off-by: Manjusaka <me@manjusaka.me>

brandtbucher

Looks good! Just one last suggestion for the test:

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli · 2025-05-20T21:27:05Z

Looks good! Just one last suggestion for the test:

Thanks for your patience and review. Learn a lot in this PR. I think I can find a new opcode to write! Thanks again ♥️@brandtbucher @tomasr8

…133345)

Zheaoli requested a review from Fidget-Spinner as a code owner May 3, 2025 14:32

bedevere-appBot mentioned this pull request May 3, 2025
Better uop coverage in the JIT optimizer #131798
Open

bedevere-appBot added the awaiting review label May 3, 2025

tomasr8 reviewed May 3, 2025
View reviewed changes

Comment threadLib/test/test_capi/test_opt.py Outdated

ZeroIntensity added the topic-JIT label May 3, 2025

Fidget-Spinner approved these changes May 4, 2025
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting review labels May 4, 2025

brandtbucher requested changes May 6, 2025
View reviewed changes

Comment threadLib/test/test_capi/test_opt.py Outdated
Comment threadPython/optimizer_bytecodes.c Outdated
Comment threadPython/optimizer_bytecodes.c Outdated

bedevere-appBot removed the awaiting merge label May 6, 2025

bedevere-appBot added the awaiting changes label May 6, 2025

Zheaoli added 5 commits May 8, 2025 15:03

pythongh-131798: JIT: Narrow the return type of _GET_LEN to int
cabe8f1
Signed-off-by: Manjusaka <me@manjusaka.me>

Add news
1f8a607
Signed-off-by: Manjusaka <me@manjusaka.me>

Fix typo
f2f71d9
Signed-off-by: Manjusaka <me@manjusaka.me>

Fix review idea
1662b47
Signed-off-by: Manjusaka <me@manjusaka.me>

Fix review idea
52ce698
Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli force-pushed the manjusaka/get-len branch from ad1f5df to 52ce698Compare May 8, 2025 07:07

Fix review idea
b1640ed
Signed-off-by: Manjusaka <me@manjusaka.me>

bedevere-appBot added awaiting change review and removed awaiting changes labels May 8, 2025

bedevere-appBot requested review from Fidget-Spinner and brandtbucher May 8, 2025 07:46

brandtbucher requested changes May 8, 2025
View reviewed changes

Comment threadPython/optimizer_bytecodes.c
Comment threadPython/optimizer_bytecodes.c Outdated

bedevere-appBot added awaiting changes and removed awaiting change review labels May 8, 2025

Zheaoli added 4 commits May 21, 2025 04:12

fix review idea
d1e3a2b
Signed-off-by: Manjusaka <me@manjusaka.me>

fix review idea
e0e3745
Signed-off-by: Manjusaka <me@manjusaka.me>

fix review idea
81c4996
Signed-off-by: Manjusaka <me@manjusaka.me>

fix review idea
93e1e86
Signed-off-by: Manjusaka <me@manjusaka.me>

bedevere-appBot added awaiting change review and removed awaiting changes labels May 20, 2025

bedevere-appBot requested a review from brandtbucher May 20, 2025 20:21

fix review idea
6b5282f
Signed-off-by: Manjusaka <me@manjusaka.me>

tomasr8 reviewed May 20, 2025
View reviewed changes

Comment threadLib/test/test_capi/test_opt.py Outdated

Zheaoli added 2 commits May 21, 2025 04:59

fix review idea
2eefeb3
Signed-off-by: Manjusaka <me@manjusaka.me>

fix review idea
9c58f2c
Signed-off-by: Manjusaka <me@manjusaka.me>

brandtbucher approved these changes May 20, 2025
View reviewed changes

Comment threadLib/test/test_capi/test_opt.py

bedevere-appBot added awaiting merge and removed awaiting change review labels May 20, 2025

Zheaoli added 3 commits May 21, 2025 05:13

fix review idea
f9822e9
Signed-off-by: Manjusaka <me@manjusaka.me>

fix review idea
6a06aff
Signed-off-by: Manjusaka <me@manjusaka.me>

fix review idea
6d92614
Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli requested a review from brandtbucher May 20, 2025 21:14

format code
5cfbad4
Signed-off-by: Manjusaka <me@manjusaka.me>

brandtbucher approved these changes May 20, 2025
View reviewed changes

brandtbucher merged commit e1c0c45 into python:mainMay 20, 2025

bedevere-appBot removed the awaiting merge label May 20, 2025

Zheaoli deleted the manjusaka/get-len branch May 20, 2025 22:23

lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…
274e5d5
…133345)

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…
6ddc201
…133345)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…
fbb8996
…133345)

gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…
b8e48ba
…133345)

Uh oh!

Uh oh!

Conversation

Zheaoli commented May 3, 2025• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-appBot commented May 6, 2025

Uh oh!

Zheaoli commented May 8, 2025

Uh oh!

bedevere-appBot commented May 8, 2025

Uh oh!

Zheaoli commented May 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-appBot commented May 8, 2025

Uh oh!

Zheaoli commented May 20, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-appBot commented May 20, 2025

Uh oh!

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zheaoli commented May 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zheaoli commented May 3, 2025•
edited by bedevere-app Bot
Loading

Zheaoli commented May 8, 2025•
edited
Loading

Zheaoli commented May 20, 2025•
edited
Loading