gh-133439: Fix dot commands with trailing spaces are mistaken for multi-line sqlite statements in the sqlite3 command-line interface by tanloong · Pull Request #133440 · python/cpython

tanloong · 2025-05-05T14:17:12Z

Issue: sqlite3 CLI does not recognize dot commands with trailing spaces #133439

Issue: sqlite3 CLI does not recognize dot commands with trailing spaces #133439

serhiy-storchaka

The sqlite3 CLI supports also space after dot:

sqlite> . version
SQLite 3.45.1 2024-01-30 16:01:20 e876e51a0ed5c5b3126f52e532044363a014bc594cfefa87ffb5b82257ccalt1
zlib version 1.3
gcc-13.3.0 (64-bit)

But not before dot:

sqlite> .version
...>

To be conforming with it, we should check if the first character is a dot, and if it is, use source[1:].strip() as the command. No stripping is needed for the SQL statement.

…ized in sqlite3 CLI

tanloong · 2025-05-09T08:21:10Z

Thank you for your review! I have modified the code to use source[1:].strip() as dot command, no stripping for SQL statement.

tanloong · 2025-05-09T09:55:02Z

Sorry for the overlook, now the empty source and unknown dot commands are handled. I have improved the news entry.

serhiy-storchaka

LGTM. 👍

miss-islington-app · 2025-05-09T11:41:13Z

Thanks @tanloong for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

…or multi-line sqlite statements in the sqlite3 command-line interface (pythonGH-133440) (cherry picked from commit ebd4881) Co-authored-by: Tan Long <tanloong@foxmail.com>

bedevere-app · 2025-05-09T11:41:25Z

GH-133738 is a backport of this pull request to the 3.14 branch.

picnixz · 2025-05-09T11:44:37Z

@serhiy-storchaka no 3.13 backports?

…for multi-line sqlite statements in the sqlite3 command-line interface (GH-133440) (GH-133738) (cherry picked from commit ebd4881) Co-authored-by: Tan Long <tanloong@foxmail.com>

serhiy-storchaka · 2025-05-09T14:27:29Z

This is borderline between minor bug fix and minor feature. It improves the quality of life a little, but most people won't notice anything. If anyone wants to backport to 3.13, please do. If not, no problem either.

tanloong · 2025-05-09T14:42:01Z

I will do that.

bedevere-app · 2025-05-09T14:44:09Z

GH-133765 is a backport of this pull request to the 3.13 branch.

serhiy-storchaka · 2025-05-09T14:45:36Z

@tanloong, I meant any of the core developers. It's as simple as adding a label. Someone just has to want to do it.

tanloong · 2025-05-09T14:49:58Z

Ah, sorry, I misunderstood.

…or multi-line sqlite statements in the sqlite3 command-line interface (pythonGH-133440) (cherry picked from commit ebd4881)

StanFromIreland · 2025-05-10T08:04:38Z

+ pass
+ case _ as unknown:
+ self.write("Error: unknown command or invalid arguments:"
+ f' "{unknown}".\n')


Error messages do not end with a '.' e.g.:
Python 3.15.0a0 (heads/main:c81fa2b9cd1, May 8 2025, 16:38:25) [GCC 15.1.1 20250425 (Red Hat 15.1.1-1)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> test Traceback (most recent call last): File "<python-input-0>", line 1, in <module> test NameError: name 'test' is not defined

…for multi-line sqlite statements in the sqlite3 command-line interface (GH-133440) (GH-133765) (cherry picked from commit ebd4881)

…or multi-line sqlite statements in the sqlite3 command-line interface (pythonGH-133440)

tanloong requested review from berkerpeksag and erlend-aasland as code owners May 5, 2025 14:17

bedevere-appBot mentioned this pull request May 5, 2025
sqlite3 CLI does not recognize dot commands with trailing spaces #133439
Closed

bedevere-appBot added the awaiting review label May 5, 2025

tanloong force-pushed the sqlite3-cli-strip-whitespaces branch from d756211 to 0d89da8Compare May 6, 2025 13:11

serhiy-storchaka reviewed May 9, 2025
View reviewed changes

tanloong added 3 commits May 9, 2025 16:18

pythongh-133439: fix dot commands with trailing spaces are not recogn…
080d0c8
…ized in sqlite3 CLI

Add news entry
cd277f3

Only strip trailing whitespaces
e2703b4

tanloong force-pushed the sqlite3-cli-strip-whitespaces branch from 0d89da8 to 3543c33Compare May 9, 2025 08:19

Support spaces after dot
a4498ab

tanloong force-pushed the sqlite3-cli-strip-whitespaces branch from 3543c33 to a4498abCompare May 9, 2025 08:24

serhiy-storchaka reviewed May 9, 2025
View reviewed changes

Comment threadLib/sqlite3/__main__.py
Comment threadLib/sqlite3/__main__.py
Comment threadMisc/NEWS.d/next/Library/2025-05-05-22-11-24.gh-issue-133439.LpmyFz.rst Outdated

tanloong added 2 commits May 9, 2025 17:28

Handle unknown dot commands
9b3ed39

Add tests for unknown dot commands
4023fb1

tanloong force-pushed the sqlite3-cli-strip-whitespaces branch from cbea2b1 to 487aafcCompare May 9, 2025 09:50

Handle empty string input; Add test; Improve news entry
b473fe9

tanloong force-pushed the sqlite3-cli-strip-whitespaces branch from 487aafc to b473fe9Compare May 9, 2025 09:52

tanloong added 2 commits May 9, 2025 18:00

Use as-patern to capture the unknow command
bb0c7d9

Ignore empty dot command
5ec7198

serhiy-storchaka reviewed May 9, 2025
View reviewed changes

Comment threadLib/sqlite3/__main__.py Outdated
Comment threadLib/sqlite3/__main__.py Outdated
Comment threadLib/sqlite3/__main__.py Outdated

Remove "Enter .help" message; Redirect error to stderr
caf47bc

tanloong force-pushed the sqlite3-cli-strip-whitespaces branch from 36b4a16 to caf47bcCompare May 9, 2025 11:07

serhiy-storchaka approved these changes May 9, 2025
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting review labels May 9, 2025

serhiy-storchaka enabled auto-merge (squash) May 9, 2025 11:11

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 9, 2025

Fix test
e1ea159

auto-merge was automatically disabled May 9, 2025 11:13
Head branch was pushed to by a user without write access

serhiy-storchaka enabled auto-merge (squash) May 9, 2025 11:15

serhiy-storchaka merged commit ebd4881 into python:mainMay 9, 2025

bedevere-appBot removed the awaiting merge label May 9, 2025

bedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 9, 2025

erlend-aasland reviewed May 10, 2025
View reviewed changes

Comment threadLib/sqlite3/__main__.py

erlend-aasland mentioned this pull request May 10, 2025
gh-133447: Add basic color to sqlite3 CLI #133461
Merged

StanFromIreland reviewed May 10, 2025
View reviewed changes

serhiy-storchaka pushed a commit that referenced this pull request Jun 13, 2025
[3.13]gh-133439: Fix dot commands with trailing spaces are mistaken …
22cf289
…for multi-line sqlite statements in the sqlite3 command-line interface (GH-133440) (GH-133765) (cherry picked from commit ebd4881)

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-133439: Fix dot commands with trailing spaces are mistaken f…
9fde33a
…or multi-line sqlite statements in the sqlite3 command-line interface (pythonGH-133440)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-133439: Fix dot commands with trailing spaces are mistaken f…
b75cacf
…or multi-line sqlite statements in the sqlite3 command-line interface (pythonGH-133440)

tanloong deleted the sqlite3-cli-strip-whitespaces branch May 1, 2026 06:03

Uh oh!

Uh oh!

Conversation

tanloong commented May 5, 2025• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

tanloong commented May 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tanloong commented May 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-appBot commented May 9, 2025

Uh oh!

bedevere-appBot commented May 9, 2025

Uh oh!

picnixz commented May 9, 2025

Uh oh!

serhiy-storchaka commented May 9, 2025

Uh oh!

tanloong commented May 9, 2025

Uh oh!

bedevere-appBot commented May 9, 2025

Uh oh!

serhiy-storchaka commented May 9, 2025

Uh oh!

tanloong commented May 9, 2025

Uh oh!

Uh oh!

StanFromIrelandMay 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tanloong commented May 5, 2025•
edited by bedevere-app Bot
Loading