Skip to content

GH-133261: Make sure trashcan pointers look mortal -- 32 bit - #133450

Merged
ambv merged 1 commit into
python:mainfrom
faster-cpython:fix-133261-32bit
May 5, 2025
Merged

GH-133261: Make sure trashcan pointers look mortal -- 32 bit#133450
ambv merged 1 commit into
python:mainfrom
faster-cpython:fix-133261-32bit

Conversation

@markshannon

@markshannonmarkshannon commented May 5, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 5, 2025
Closed
@markshannon
markshannon requested a review from vstinnerMay 5, 2025 16:30
@markshannon

markshannon commented May 5, 2025

Copy link
Copy Markdown
MemberAuthor

!buildbot "x86 Debian"

@bedevere-bot

bedevere-bot commented May 5, 2025

Copy link
Copy Markdown

The regex '"x86 Debian"' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@markshannon

markshannon commented May 5, 2025

Copy link
Copy Markdown
MemberAuthor

!buildbot x86 Debian

@bedevere-bot

bedevere-bot commented May 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 2ef7ee5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133450%2Fmerge

The command will test the builders whose names match following regular expression: x86 Debian

The builders matched are:

  • x86 Debian Non-Debug with X PR
  • x86 Debian Installed with X PR

@markshannonmarkshannon changed the title GH-133261: Make sure trashcan pointer look mortal -- 32 bitGH-133261: Make sure trashcan pointers look mortal -- 32 bitMay 5, 2025
vstinner
vstinner approved these changes May 5, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadObjects/object.c
}
return (void *)(refcnt - 2);
#else
return (void *)((refcnt -1) << 2);

@vstinnervstinnerMay 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return (void*)((refcnt-1) << 2);
return (void*)((refcnt-1) << 2);

@vstinner

vstinner commented May 5, 2025

Copy link
Copy Markdown
Member

buildbot/x86 Debian Installed with X PR — Build done.
buildbot/x86 Debian Non-Debug with X PR — Build done.

Nice, the fix works as expected, tests passed on two buildbot workers.

@vstinner

vstinner commented May 5, 2025

Copy link
Copy Markdown
Member

I built Python using CFLAGS=-m32 (on Linux x86-64) but I failed to reproduce the issue.

I built Python in a x86 (32-bit) container, but I failed to reproduce the issue.

But this change looks correct, it should fix the issue, and the buildbots confirmed that the fix works.

@ambv
ambv merged commit d48616e into python:mainMay 5, 2025
@markshannon
markshannon deleted the fix-133261-32bit branch May 6, 2025 08:22
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@markshannon@Pranjal095
pythonGH-133261: Make sure trashcan pointers look mortal -- 32 bit (p…
8153f7b
…ythonGH-133450)
Make sure trashcan pointer look mortal -- 32 bit
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon@bedevere-bot@vstinner@ambv