gh-133403: Type Tools/build/verify_ensurepip_wheels.py and check it with mypy by Flosckow · Pull Request #133453 · python/cpython

Flosckow · 2025-05-05T16:40:31Z

Add typing for verify_ensurepip_wheels and check it with mypy.
related to #133403 (comment)

Issue: Add typing to more build tools #133403

…k it with mypy

bedevere-app · 2025-05-05T16:40:40Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

sobolevn

Thanks! Several suggestions

sobolevn

I can't merge your PR right now, because we are waiting for the first 3.14 beta release and the branch is locked. https://discuss.python.org/t/python-3-14-0-beta-1-is-near/90921

But, this looks good to me. Thanks a lot!
Congrats on your first CPython PR 🎉

Flosckow · 2025-05-06T09:19:34Z

@sobolevn, thx for your review))

sobolevn

I fixed the merge conflicts for you, but please, add new dependencies for mypy job here:

cpython/.github/workflows/mypy.yml

Line 16 in 8679c8d

- "Tools/build/generate_sbom.py"

So, it would match definitions in our mypy.ini file.

python-cla-bot · 2025-05-08T13:05:12Z

All commit authors signed the Contributor License Agreement.

Flosckow · 2025-05-08T13:07:10Z

@sobolevn, thx, I have added the check to the workflow.

sobolevn

Thank you!

miss-islington-app · 2025-05-08T17:53:51Z

Thanks @Flosckow for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…mypy (pythonGH-133453) (cherry picked from commit 5f3d3f2) Co-authored-by: Flosckow <66554425+Flosckow@users.noreply.github.com> Co-authored-by: Daniil Dumchenko <dumchenko.de@sibvaleo.com> Co-authored-by: sobolevn <mail@sobolevn.me>

bedevere-app · 2025-05-08T17:54:03Z

GH-133689 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2025-05-08T17:54:07Z

GH-133690 is a backport of this pull request to the 3.13 branch.

… mypy (GH-133453) (#133690) gh-133403: Check `Tools/build/verify_ensurepip_wheels.py` with mypy (GH-133453) (cherry picked from commit 5f3d3f2) Co-authored-by: Flosckow <66554425+Flosckow@users.noreply.github.com> Co-authored-by: Daniil Dumchenko <dumchenko.de@sibvaleo.com> Co-authored-by: sobolevn <mail@sobolevn.me>

… mypy (GH-133453) (#133689) gh-133403: Check `Tools/build/verify_ensurepip_wheels.py` with mypy (GH-133453) (cherry picked from commit 5f3d3f2) Co-authored-by: Flosckow <66554425+Flosckow@users.noreply.github.com> Co-authored-by: Daniil Dumchenko <dumchenko.de@sibvaleo.com> Co-authored-by: sobolevn <mail@sobolevn.me>

bedevere-bot · 2025-05-08T19:14:04Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.13 (tier-3) has failed when building commit c2cddb7.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1386/builds/1298) and take a look at the build logs.
Check if the failure is related to this commit (c2cddb7) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1386/builds/1298

Failed tests:

test_socket

Failed subtests:

testSourceAddress - test.test_socket.NetworkConnectionAttributesTest.testSourceAddress
test_UnixDatagramServer - test.test_socketserver.SocketServerTest.test_UnixDatagramServer

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/threading.py", line 1041, in _bootstrap_innerself.run()
~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/threading.py", line 992, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 240, in serve_foreverself._handle_request_noblock()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 320, in _handle_request_noblockself.handle_error(request, client_address)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 318, in _handle_request_noblockself.process_request(request, client_address)
~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 349, in process_requestself.finish_request(request, client_address)
~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 362, in finish_requestself.RequestHandlerClass(request, client_address, self)
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 768, in __init__self.finish()
~~~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 863, in finishself.socket.sendto(self.wfile.getvalue(), self.client_address)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ConnectionResetError: [Errno 54] Connection reset by peer
ERROR
Traceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/test/test_socketserver.py", line 222, in test_UnixDatagramServerself.run_server(socketserver.UnixDatagramServer,
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
socketserver.DatagramRequestHandler,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^self.dgram_examine)
^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/test/support/threading_helper.py", line 66, in decoratorreturn func(*args)
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/test/test_socketserver.py", line 133, in run_server
testfunc(svrcls.address_family, addr)
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/test/test_socketserver.py", line 160, in dgram_examine
buf = data = receive(s, 100)
~~~~~~~^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/test/test_socketserver.py", line 43, in receiveraiseRuntimeError("timed out on %r"% (sock,))
RuntimeError: timed out on <socket.socket fd=23, family=1, type=2, proto=0, laddr=./test_python_rn15bc39.sock>
Traceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/test/test_socket.py", line 417, in raise_queued_exceptionraiseself.queue.get()
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/test/test_socket.py", line 454, in clientRun
test_func()
~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9449EF01-B9BB-463B-BC72-6BBF98F28897/data/Containers/Bundle/Application/57FFADF3-7B3F-4171-9706-296D30AE6DB0/iOSTestbed.app/python/lib/python3.13/test/test_socket.py", line 5783, in _testSourceAddressself.assertEqual(self.cli.getsockname()[1], self.source_port)
~~~~~~~~~~~~~~~~~~~~^^OSError: [Errno 9] Bad file descriptor

…mypy (python#133453) Co-authored-by: Daniil Dumchenko <dumchenko.de@sibvaleo.com> Co-authored-by: sobolevn <mail@sobolevn.me>

pythongh-133403: Type Tools/build/verify_ensurepip_wheels.py and chec…
1d9a5c0
…k it with mypy

Flosckow requested review from pfmoore and pradyunsg as code owners May 5, 2025 16:40

bedevere-appBot mentioned this pull request May 5, 2025
Add typing to more build tools #133403
Closed

bedevere-appBot added the awaiting review label May 5, 2025

sobolevn added the skip news label May 5, 2025

sobolevn reviewed May 5, 2025
View reviewed changes

Comment threadTools/build/verify_ensurepip_wheels.py
Comment threadTools/build/verify_ensurepip_wheels.py Outdated
Comment threadTools/build/verify_ensurepip_wheels.py Outdated
Comment threadTools/build/verify_ensurepip_wheels.py Outdated

Fix: comments
a63dcfd

sobolevn approved these changes May 6, 2025
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting review labels May 6, 2025

Merge branch 'main' into issue-133403
5ddf0ed

sobolevn reviewed May 8, 2025
View reviewed changes

picnixz changed the title ~~pythongh-133403: Type Tools/build/verify_ensurepip_wheels.py and check it with mypy~~gh-133403: Type Tools/build/verify_ensurepip_wheels.py and check it with mypyMay 8, 2025

Changed: add verify to gh workflow
00f7e1d

Flosckow requested review from AA-Turner, ezio-melotti and hugovk as code owners May 8, 2025 13:04

Merge branch 'main' into issue-133403
2a6ee86

sobolevn reviewed May 8, 2025
View reviewed changes

Comment thread.github/workflows/mypy.yml
Comment threadTools/build/mypy.ini

Changed: add another build files to workflow, add reminder
31854d5

sobolevn approved these changes May 8, 2025
View reviewed changes

Comment threadTools/build/mypy.ini Outdated

Update Tools/build/mypy.ini
b7c013a

sobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 8, 2025

Merge branch 'main' into issue-133403
e839848

sobolevn enabled auto-merge (squash) May 8, 2025 17:27

sobolevn merged commit 5f3d3f2 into python:mainMay 8, 2025

bedevere-appBot removed the awaiting merge label May 8, 2025

bedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 8, 2025

bedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 8, 2025

Uh oh!

Uh oh!

Conversation

Flosckow commented May 5, 2025• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-appBot commented May 5, 2025

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Flosckow commented May 6, 2025

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

python-cla-botBot commented May 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flosckow commented May 8, 2025

Uh oh!

Uh oh!

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-appBot commented May 8, 2025

Uh oh!

bedevere-appBot commented May 8, 2025

Uh oh!

bedevere-appBot commented May 8, 2025

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Flosckow commented May 5, 2025•
edited by bedevere-app Bot
Loading

python-cla-botBot commented May 8, 2025•
edited
Loading