Uh oh!
There was an error while loading. Please reload this page.
gh-132775: Add _PyFunction_GetXIData() - #133481
Merged
ericsnowcurrently merged 2 commits intoMay 12, 2025
Merged
Conversation
ericsnowcurrentlyforce-pushed
the
add-pyfunction-getxidata
branch
from
May 8, 2025 16:07
d762347 to
4a195d8Compareericsnowcurrently
marked this pull request as ready for review
May 8, 2025 16:08
neonene
reviewed
May 8, 2025
| if (_PyFunction_VerifyStateless(tstate, func) < 0) { | ||
| PyObject *cause = _PyErr_GetRaisedException(tstate); | ||
| assert(cause != NULL); | ||
| const char *msg = "non-stateless functions are not shareable"; |
Contributor
There was a problem hiding this comment.
Not confusing, but the triple negation (non, less, not) looks a bit redundant. I do not think NotShareableError needs "not shareable" in the message.
ericsnowcurrently
enabled auto-merge (squash)
May 12, 2025 21:44
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 12, 2025
(cherry picked from commit 8cf4947) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
GH-133955 is a backport of this pull request to the 3.14 branch. |
bedevere-bot
commented
May 12, 2025
|
ericsnowcurrently added a commit
that referenced
this pull request
May 12, 2025
ericsnowcurrently added a commit
that referenced
this pull request
May 27, 2025
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 27, 2025
…ythongh-134758) This is a small follow-up to pythongh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set. (cherry picked from commit 9b5e800) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently added a commit
that referenced
this pull request
May 27, 2025
…gh-134794) This is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set. (cherry picked from commit 9b5e800, AKA gh-134758) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Pranjal095 pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
Pranjal095 pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…ythongh-134758) This is a small follow-up to pythongh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set.
taegyunkim pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
taegyunkim pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…ythongh-134758) This is a small follow-up to pythongh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set.
gostak-dd pushed a commit
to gostak-dd/cpython
that referenced
this pull request
Jun 2, 2026
…ythongh-134758) This is a small follow-up to pythongh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects __builtins__ to be set if __globals__ is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is based on gh-133480, thus only the last commit.)