GH-132983: Remove zstd version check in the header file

[AA-Turner]

We now have better version detection in autoconf, including detecting the most recent symbol we used. A hard version check in the header file can lead to spurious failures when using zstd versions between 1.1.3 (symbol added) and 1.4.5 (symbol stabilised).

xref:

• Revert "gh-133395: add option for extension modules to specialize BINARY_OP/SUBSCR, apply to arrays (#133396)" #133498 (failing due to the check)
• gh-132983: Introduce _zstd bindings module #133027 (added the check)

A

• Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

[encukou]

Argh!
The header file puts it in an #ifdef ZDICT_STATIC_LINKING_ONLY block, saying it's experimental. But, configure looks for the exported function symbol.

[AA-Turner]

cc @encukou@vstinner I'm confused by this error as the struct has existed with the members that we need since v0.7 (2016) of libzstd. Do you have any suggestions?

A

[AA-Turner]

Is it worth setting the ZDICT_STATIC_LINKING_ONLY define? The other option is to remove the fallback symbol detection and have autoconf just check for >=1.4.5.

[encukou]

IMO, the >=1.4.5 check is safer.

[AA-Turner]

For reference, v1.4.4 and earlier guarded the symbol behind a define. It was stabilised (facebook/zstd#2111) in v1.4.5.

[AA-Turner]

free-threaded tsan failure is spurious: 1 test failed: test_asyncio.test_free_threading

[encukou]

test_datetime's [24, 24, 24] leaks are also spurious: this PR doesn't include #133498. I checked:

• buildbot/AMD64 CentOS9 NoGIL Refleaks PR
• buildbot/ARM64 MacOS M1 Refleaks NoGIL PR
• buildbot/PPC64LE RHEL8 Refleaks PR

[AA-Turner]

The buildbots don't seem to have scheduled

[hugovk]

The buildbots don't seem to have scheduled

Same thing happened at #133497 (comment). Trying again worked.

[AA-Turner]

I'm still not seeing e.g. 'AMD64 RHEL8 LTO PR' in the pending checks list?

[AA-Turner]

buildbot/PPC64LE RHEL8 Refleaks PR failures are the leaks:

test_datetime leaked [24, 24, 24] memory blocks, sum=72
FAIL: test_interrupt (test.test_multiprocessing_spawn.test_processes.WithProcessesTestProcess.test_interrupt)
Re-running test.test_multiprocessing_spawn.test_processes in verbose mode (matching: test_interrupt)
Re-running test_datetime in verbose mode
test_datetime leaked [24, 24, 24] memory blocks, sum=72

[encukou]

AMD64 RHEL8 FIPS No Builtin Hashes is unstable; failed in the usual way here.

[hugovk]

Looking good so far, let's merge. Thanks both!