Skip to content

gh-132983: Remove pyzstd in identifiers - #133535

Merged
AA-Turner merged 3 commits into
python:mainfrom
Rogdham:remove-pyzstd-in-identifiers
May 8, 2025
Merged

gh-132983: Remove pyzstd in identifiers#133535
AA-Turner merged 3 commits into
python:mainfrom
Rogdham:remove-pyzstd-in-identifiers

Conversation

@Rogdham

@RogdhamRogdham commented May 6, 2025

Copy link
Copy Markdown
Contributor

The _PyZstd_xxx extern functions were leftover artifacts of the move from pyzstd to cpython.

I have renamed them to the _zstd_xxx convention used for private functions.

@python-cla-bot

python-cla-botBot commented May 6, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@Rogdham
Rogdham marked this pull request as ready for review May 6, 2025 20:04
@Rogdham

Copy link
Copy Markdown
ContributorAuthor

Thanks @emmatyping for the explanation about the context, pinging you for review as suggested 🤗

@emmatypingemmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just want to make sure we make these static since they are local to their translation unit (file).

Comment threadModules/_zstd/compressor.c Outdated
Comment threadModules/_zstd/compressor.c Outdated
Comment threadModules/_zstd/decompressor.c Outdated
Comment threadModules/_zstd/decompressor.c Outdated

@emmatypingemmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure looks unrelated. Thanks for the PR!

@AA-Turner

Copy link
Copy Markdown
Member

Note: in general we don't need to update the branch, it wastes CI resources. I tend to do so only sparingly.

@AA-Turner
AA-Turner merged commit 2cc6de7 into python:mainMay 8, 2025
@AA-TurnerAA-Turner added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@miss-islington-app

Copy link
Copy Markdown

Thanks @Rogdham for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2025
(cherry picked from commit 2cc6de7)
Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>
@bedevere-app

Copy link
Copy Markdown

GH-133629 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 8, 2025
@emmatyping

Copy link
Copy Markdown
Member

Note: in general we don't need to update the branch, it wastes CI resources. I tend to do so only sparingly.

I only did so to sort out CI failures which would block merge.

@AA-Turner

Copy link
Copy Markdown
Member

Sorry! I missed that, thanks.

@Rogdham
Rogdham deleted the remove-pyzstd-in-identifiers branch May 8, 2025 05:51
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Rogdham@AA-Turner@emmatyping