Skip to content

gh-131178: Add tests for site command-line interface - #133582

Merged
ZeroIntensity merged 15 commits into
python:mainfrom
ggqlq:add_tests_for_site_cli
Aug 15, 2025
Merged

gh-131178: Add tests for site command-line interface #133582
ZeroIntensity merged 15 commits into
python:mainfrom
ggqlq:add_tests_for_site_cli

Conversation

@ggqlq

@ggqlqggqlq commented May 7, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@ggqlq
ggqlq requested a review from FFY00 as a code ownerMay 7, 2025 14:41
@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label May 7, 2025
@bedevere-appbedevere-appBot mentioned this pull request May 7, 2025
Open
9 tasks
@bedevere-app

This comment was marked as resolved.

Sign in to view
@ggqlq
ggqlq marked this pull request as draft May 7, 2025 16:09
@bedevere-app

This comment was marked as resolved.

Sign in to view
4 similar comments
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@ggqlq
ggqlqforce-pushed the add_tests_for_site_cli branch from bd612e2 to b1ec14dCompareMay 7, 2025 19:00
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@ggqlq
ggqlq marked this pull request as ready for review May 8, 2025 06:51
ZeroIntensity
ZeroIntensity reviewed May 11, 2025
View reviewed changes
Comment threadLib/test/test_site.py Outdated
Comment threadLib/test/test_site.py Outdated
Comment threadLib/test/test_site.py Outdated
Comment threadLib/test/test_site.py Outdated
@ZeroIntensity

ZeroIntensity commented May 11, 2025

Copy link
Copy Markdown
Member

Also: don't force push, it just makes reviewing harder and the bot louder. We squash-merge at the end.

@ggqlq
ggqlq requested a review from ZeroIntensityMay 13, 2025 06:59
@ZeroIntensityZeroIntensity added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 5, 2025
@bedevere-bot

bedevere-bot commented Jun 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit d0999d2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133582%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 5, 2025
@donbarbosdonbarbos mentioned this pull request Aug 15, 2025
Closed
ZeroIntensity
ZeroIntensity approved these changes Aug 15, 2025
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@ZeroIntensityZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 15, 2025
@ZeroIntensity
ZeroIntensity merged commit 03f5519 into python:mainAug 15, 2025
50 checks passed
@miss-islington-app

miss-islington-appBot commented Aug 15, 2025

Copy link
Copy Markdown

Thanks @ggqlq for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2025
@ggqlq@miss-islington
pythongh-131178: Add tests forsitecommand-line interface (pythonG…
2efeb8f
…H-133582)
(cherry picked from commit 03f5519)
Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2025
@ggqlq@miss-islington
pythongh-131178: Add tests forsitecommand-line interface (pythonG…
797f64e
…H-133582)
(cherry picked from commit 03f5519)
Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Aug 15, 2025

Copy link
Copy Markdown

GH-137832 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Aug 15, 2025
@bedevere-app

bedevere-appBot commented Aug 15, 2025

Copy link
Copy Markdown

GH-137833 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Aug 15, 2025
ZeroIntensity pushed a commit that referenced this pull request Aug 15, 2025
@miss-islington@ggqlq
[3.13]gh-131178: Add tests forsitecommand-line interface (GH-133582
8d6e107
) (GH-137833)
gh-131178: Add tests for `site` command-line interface (GH-133582)
(cherry picked from commit 03f5519)
Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
@ggqlq

ggqlq commented Aug 18, 2025

Copy link
Copy Markdown
ContributorAuthor

@ZeroIntensity Thank you for your review!

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@ggqlq@Agent-Hellboy
pythongh-131178: Add tests forsitecommand-line interface (python…
ed3b781
…GH-133582)
ZeroIntensity pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington@ggqlq
[3.14]gh-131178: Add tests forsitecommand-line interface (GH-133582
df739f3
) (GH-137832)
gh-131178: Add tests for `site` command-line interface (GH-133582)
(cherry picked from commit 03f5519)
Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
@itamaroitamaro mentioned this pull request Oct 15, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes
@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggqlq@ZeroIntensity@bedevere-bot