Uh oh!
There was an error while loading. Please reload this page.
gh-133597: Fix memory leak if error occurred in _sys_getwindowsversion_from_kernel32 - #133598
Conversation
sergey-miryanov
commented
May 7, 2025
I believe this PR may skip news. |
Eclips4
commented
May 7, 2025
FYI, Sergey, the CI fails due to the recent beta(3.14b1) release. I'll restart it later. |
sergey-miryanov
commented
May 7, 2025
Thanks! Yeah, I saw a possible fix #133599 |
Thanks @sergey-miryanov for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…version_from_kernel32 (pythonGH-133598) (cherry picked from commit 0ec8fc8) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
…version_from_kernel32 (pythonGH-133598) (cherry picked from commit 0ec8fc8) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
GH-133659 is a backport of this pull request to the 3.14 branch. |
GH-133660 is a backport of this pull request to the 3.13 branch. |
bedevere-bot
commented
May 8, 2025
|
…version_from_kernel32 (pythonGH-133598)
…version_from_kernel32 (pythonGH-133598)
If
GetFileVersionInfoWorVerQueryValueWfails inside_sys_getwindowsversion_from_kernel32then allocatedverblocknot freed.