Skip to content

gh-133601: Remove deprecated typing.no_type_check_decorator - #133602

Merged
sobolevn merged 8 commits into
python:mainfrom
sobolevn:issue-133601
Oct 20, 2025
Merged

gh-133601: Remove deprecated typing.no_type_check_decorator#133602
sobolevn merged 8 commits into
python:mainfrom
sobolevn:issue-133601

Conversation

@sobolevn

@sobolevnsobolevn commented May 7, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 7, 2025
Closed
@Eclips4Eclips4 mentioned this pull request May 7, 2025
Closed
@AlexWaygoodAlexWaygood mentioned this pull request May 10, 2025
Closed
picnixz
picnixz reviewed May 10, 2025
View reviewed changes

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update Doc/whatsnew/3.15.rst as well?

@picnixz

picnixz commented May 10, 2025

Copy link
Copy Markdown
Member

So, vendored typing_extensions of pip seems to use the attribute. Maybe we should fix pip and typing_extensions first with a version guard?

@JelleZijlstraJelleZijlstra mentioned this pull request May 10, 2025
Merged
@JelleZijlstra

JelleZijlstra commented May 10, 2025

Copy link
Copy Markdown
Member

I submitted a change to typing-extensions to stop unconditionally re-exporting this name. We should probably not merge this until that change to typing-extensions has been released.

@yashwanthatlayashwanthatla mentioned this pull request Jun 21, 2025
Open
@sobolevn
sobolevn enabled auto-merge (squash) October 20, 2025 20:51
@sobolevn
sobolevn merged commit e09837f into python:mainOct 20, 2025
45 checks passed
@asottile

asottile commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

fwiw this prevents usage of pip with the latest nightly -- perhaps this should be reverted until a pip release occurs?

(for example: this prevents promotion of deadsnakes nightly 3.15 because we check that pip, venv, and virtualenv are functioning): https://github.com/deadsnakes/py3.15/actions/runs/18678417262/job/53253774210

@AA-Turner

AA-Turner commented Oct 21, 2025

Copy link
Copy Markdown
Member

pip plans to release on Friday (24th): pypa/pip#13522 (comment)

A

@Mr0grogMr0grog mentioned this pull request Nov 20, 2025
Closed
@DaraanDaraan mentioned this pull request Nov 25, 2025
Closed
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@sobolevn@StanFromIreland
pythongh-133601: Remove deprecatedtyping.no_type_check_decorator(p…
e3f4fb5
…ython#133602)
@positaposita mentioned this pull request Feb 27, 2026
Closed
posita added a commit to beartype/beartype that referenced this pull request Feb 27, 2026
@posita
Remove no_type_check_decorator
6d386d8
`no_type_check_decorator` has been [deprecated as largely unused since
2023](python/cpython#106309) and was [removed entirely from
3.15](python/cpython#133602). Its use appears nowhere within
`beartype` except as an import to allow `beartype.typing` as a stand-in for `typing`,
which currently causes `import beartype.typing` to fail on 3.15.
Fixes#618.
@positaposita mentioned this pull request Feb 27, 2026
Closed
posita added a commit to beartype/beartype that referenced this pull request Feb 27, 2026
@posita
Remove no_type_check_decorator
1ab0b1d
`no_type_check_decorator` has been [deprecated as largely unused since
2023](python/cpython#106309) and was [removed entirely from
3.15](python/cpython#133602). Its use appears nowhere within
`beartype` except as an import to allow `beartype.typing` as a stand-in for `typing`,
which currently causes `import beartype.typing` to fail on 3.15.
Fixes#618.
posita added a commit to beartype/beartype that referenced this pull request Feb 27, 2026
@posita
Remove no_type_check_decorator for 3.15+
a5ac3ee
`no_type_check_decorator` has been [deprecated as largely unused since
2023](python/cpython#106309) and was [removed entirely from
3.15](python/cpython#133602). Its use appears nowhere within
`beartype` except as an import to allow `beartype.typing` as a stand-in for `typing`,
which currently causes `import beartype.typing` to fail on 3.15.
Fixes#618.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments
@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn@picnixz@JelleZijlstra@asottile@AA-Turner