Skip to content

gh-133610: Remove PyUnicode_AsDecoded/Encoded functions - #133612

Merged
vstinner merged 8 commits into
python:mainfrom
StanFromIreland:rem-depr-uni-c-api
May 9, 2025
Merged

gh-133610: Remove PyUnicode_AsDecoded/Encoded functions#133612
vstinner merged 8 commits into
python:mainfrom
StanFromIreland:rem-depr-uni-c-api

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented May 7, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@StanFromIrelandStanFromIreland changed the title Remove PyUnicode_AsDecoded/Encoded functionsgh-133610: Remove PyUnicode_AsDecoded/Encoded functionsMay 7, 2025
@bedevere-appbedevere-appBot mentioned this pull request May 7, 2025
Closed
@StanFromIreland

StanFromIreland commented May 8, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

cc @AA-Turner , @emmatyping for test_zstd fail https://github.com/python/cpython/actions/runs/14894216754/job/41833346355?pr=133612

@StanFromIreland

StanFromIreland commented May 8, 2025

Copy link
Copy Markdown
MemberAuthor

Request: @vstinner

vstinner
vstinner reviewed May 8, 2025
View reviewed changes
Comment threadDoc/deprecations/c-api-pending-removal-in-3.15.rst
Comment threadDoc/whatsnew/3.15.rst
vstinner
vstinner reviewed May 8, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.15.rst Outdated
Comment thread.editorconfig Outdated
vstinner
vstinner approved these changes May 8, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner

vstinner commented May 9, 2025

Copy link
Copy Markdown
Member

Tests / Ubuntu (free-threading) / build and test (ubuntu-24.04) (pull_request)

test_zstd crash:

0:12:55 load avg: 14.73 [1/3/1] test_zstd worker non-zero exit code (Exit code -11 (SIGSEGV))
Re-running test_zstd in verbose mode (matching: test_compress_locking)
test_compress_locking (test.test_zstd.FreeThreadingMethodTests.test_compress_locking) ...
Fatal Python error: Fatal Python error: Segmentation faultSegmentation fault

@vstinner

vstinner commented May 9, 2025

Copy link
Copy Markdown
Member

A code search on PyPI top 8,000 projects found 2 projects, but there are only references to these 4 removed functions, these functions are not actually used. So we should be good in terms of impact.

@vstinner
vstinner merged commit 4fd1095 into python:mainMay 9, 2025
@StanFromIreland
StanFromIreland deleted the rem-depr-uni-c-api branch May 9, 2025 15:33
@emmatyping

emmatyping commented May 9, 2025•
edited
Loading

Copy link
Copy Markdown
Member

@vstinner@StanFromIreland the zstd crash is noted in #132983 (comment). I'm still trying to figure out the cause/fix for it.

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland@Pranjal095
pythongh-133610: Remove PyUnicode_AsDecoded/Encoded functions (python…
f38f2be
…#133612)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@StanFromIreland@taegyunkim
pythongh-133610: Remove PyUnicode_AsDecoded/Encoded functions (python…
1675141
…#133612)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@encukouencukouAwaiting requested review from encukouencukou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@vstinner@emmatyping