Skip to content

gh-133530: Differentiate between min/max heaps more - #133613

Closed
StanFromIreland wants to merge 4 commits into
python:mainfrom
StanFromIreland:heapq-doc-2
Closed

gh-133530: Differentiate between min/max heaps more#133613
StanFromIreland wants to merge 4 commits into
python:mainfrom
StanFromIreland:heapq-doc-2

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented May 7, 2025

Copy link
Copy Markdown
Member

Comment threadDoc/library/heapq.rst Outdated

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has conflicts.

@rhettingerrhettinger removed their assignment May 17, 2025
@rhettinger
rhettinger removed their request for review May 17, 2025 05:37
@rhettinger

Copy link
Copy Markdown
Contributor

This looks reasonable, but I have an alternate edit in mind where the theory section is introduced with a note that it discusses min-heaps and that similar logic applies to max-heaps.

@StanFromIreland
StanFromIreland deleted the heapq-doc-2 branch July 30, 2025 21:26
@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

I'm interested to see what you will come up with:-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewdocsDocumentation in the Doc dirskip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@rhettinger@encukou@ZeroIntensity