Skip to content

gh-123299: Some copyedits to What's New in 3.14 - #133622

Merged
merwok merged 7 commits into
python:mainfrom
merwok:whatsnew-3.14-details
May 9, 2025
Merged

gh-123299: Some copyedits to What's New in 3.14#133622
merwok merged 7 commits into
python:mainfrom
merwok:whatsnew-3.14-details

Conversation

@merwok

@merwokmerwok commented May 7, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

merwok added 4 commits May 7, 2025 17:31
@merwok
minor copyedit to HTML example
2261c4d
@merwok
avoid grammar issue
0178dfb
The referent is broken between the two parts on each side of the comma.
Also, «unlike» was used twice in this paragraph, but in different directions (t-strings are better than f-strings for structured processing / t-strings are nicer than other templates because similar to f-strings!)
Rewrite sligtly to avoid these two jarring effects
@merwok
fix orphaned seealso block
62a0539
@merwok
add improved unhashable type error messages to whatsnew
e40c420
@merwok
merwok requested a review from hugovkMay 7, 2025 22:06
@merwokmerwok added the needs backport to 3.14 bugs and security fixes label May 7, 2025
@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news labels May 7, 2025
@bedevere-appbedevere-appBot mentioned this pull request May 7, 2025
Closed
@merwokmerwok mentioned this pull request May 7, 2025
Closed
merwok
merwok commented May 7, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
StanFromIreland
StanFromIreland reviewed May 7, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
merwok
merwok commented May 7, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
StanFromIreland
StanFromIreland reviewed May 7, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
StanFromIreland
StanFromIreland reviewed May 7, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
StanFromIreland
StanFromIreland reviewed May 7, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
hugovk
hugovk reviewed May 8, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
@hugovkhugovk changed the title gh-123299: Some copyedits to whatsnew 3.14gh-123299: Some copyedits to What's New in 3.14May 8, 2025
merwok
merwok commented May 8, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
vstinner
vstinner reviewed May 8, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
merwokand others added 2 commits May 8, 2025 16:23
@merwok@hugovk
edits
dfa24b8
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Éric
Merge branch 'main' into whatsnew-3.14-details
6301ed3
@merwok
merwok requested review from hugovk and vstinnerMay 8, 2025 20:24
vstinner
vstinner reviewed May 9, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst
hugovk
hugovk approved these changes May 9, 2025
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

vstinner
vstinner approved these changes May 9, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merwok
merwok merged commit de28651 into python:mainMay 9, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsMay 9, 2025
@miss-islington-app

miss-islington-appBot commented May 9, 2025

Copy link
Copy Markdown

Thanks @merwok for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@merwok
merwok deleted the whatsnew-3.14-details branch May 9, 2025 15:32
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2025
Éric@miss-islington
pythongh-123299: Some copyedits to What's New in 3.14 (pythonGH-133622)
cb5c1d1
(cherry picked from commit de28651)
Co-authored-by: Éric <earaujo@caravan.coop>
@bedevere-app

bedevere-appBot commented May 9, 2025

Copy link
Copy Markdown

GH-133771 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 9, 2025
hugovk pushed a commit that referenced this pull request May 9, 2025
@miss-islingtonÉric
[3.14]gh-123299: Some copyedits to What's New in 3.14 (GH-133622) (#…
4e57e21
…133771)
Co-authored-by: Éric <earaujo@caravan.coop>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Éric@Pranjal095
pythongh-123299: Some copyedits to What's New in 3.14 (python#133622)
ea441a9
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Éric@taegyunkim
pythongh-123299: Some copyedits to What's New in 3.14 (python#133622)
e402475
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments
@vstinnervstinnervstinner approved these changes
@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@merwok@vstinner@hugovk@StanFromIreland