Uh oh!
There was an error while loading. Please reload this page.
gh-133644: remove deprecated Python initialization getter functions - #133661
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
May 8, 2025
The 2 following projects refer to these removed getter functions:
|
Uh oh!
There was an error while loading. Please reload this page.
picnixz
commented
May 9, 2025
Should we actually open issues out there? (I can do it) |
vstinner
commented
May 9, 2025
You can open an issue in the upstream projects: Or even propose a fix :-) |
vstinner
commented
May 9, 2025
The CI was sick on this PR, so I tried to close/reopen the issue to repair the CI. |
picnixz
commented
May 9, 2025
Let's do that :) (just finishing up my reviews elsewhere) |
picnixz
commented
May 9, 2025
Oh, for Nuitka the usage is fine (https://github.com/Nuitka/Nuitka/blob/4feeaf96be22b38993b7872f4e2df816fd206c27/nuitka/build/static_src/MainProgram.c#L194-L198): #elif PYTHON_VERSION < 0x370
PySys_SetPath(getBinaryDirectoryWideChars(true));
Py_SetPath(getBinaryDirectoryWideChars(true));
// NUITKA_PRINTF_TRACE("Final Py_GetPath is '%ls'.\n", Py_GetPath());#endifIt's only being used in Python 3.7 and before (well, they are directly accessing the structure members otherwise...). |
vstinner
commented
May 9, 2025
|
vstinner
commented
May 9, 2025
Merged, thank you. |
…ions (python#133661) Remove functions: * Py_GetExecPrefix() * Py_GetPath() * Py_GetPrefix() * Py_GetProgramFullPath() * Py_GetProgramName() * Py_GetPythonHome()
…ions (python#133661) Remove functions: * Py_GetExecPrefix() * Py_GetPath() * Py_GetPrefix() * Py_GetProgramFullPath() * Py_GetProgramName() * Py_GetPythonHome()
For now, I'm only removing the getters. The setters will be removed in a separate PR (it's a bit tricky to remove them in this PR as
PyConfig_Getrequires the GIL to be held)📚 Documentation preview 📚: https://cpython-previews--133661.org.readthedocs.build/