Skip to content

gh-133403: Check Tools/build/generate-build-details.py with mypy - #133735

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-133403-2
May 9, 2025
Merged

gh-133403: Check Tools/build/generate-build-details.py with mypy#133735
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-133403-2

Conversation

@sobolevn

@sobolevnsobolevn commented May 9, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@sobolevn
sobolevn requested a review from FFY00May 9, 2025 09:26
@sobolevnsobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 9, 2025
@bedevere-appbedevere-appBot mentioned this pull request May 9, 2025
Closed
@sobolevn
sobolevn merged commit cd2f234 into python:mainMay 9, 2025
@miss-islington-app

miss-islington-appBot commented May 9, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2025
@sobolevn@miss-islington
pythongh-133403: CheckTools/build/generate-build-details.pywith m…
a75917b
…ypy (pythonGH-133735)
(cherry picked from commit cd2f234)
Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app

miss-islington-appBot commented May 9, 2025

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cd2f234ad2ddd95e2d650edac5a6d593c865756a 3.13

@bedevere-app

bedevere-appBot commented May 9, 2025

Copy link
Copy Markdown

GH-133764 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 9, 2025
@sobolevn

sobolevn commented May 9, 2025

Copy link
Copy Markdown
MemberAuthor

There's no Tools/build/generate-build-details.py on 3.13, so - skipping.

@sobolevnsobolevn removed the needs backport to 3.13 bugs and security fixes label May 9, 2025
sobolevn added a commit that referenced this pull request May 9, 2025
@miss-islington@sobolevn
[3.14]gh-133403: CheckTools/build/generate-build-details.pywith …
bd6aad0
…mypy (GH-133735) (#133764)
gh-133403: Check `Tools/build/generate-build-details.py` with mypy (GH-133735)
(cherry picked from commit cd2f234)
Co-authored-by: sobolevn <mail@sobolevn.me>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn@Pranjal095
pythongh-133403: CheckTools/build/generate-build-details.pywith m…
12b94ae
…ypy (python#133735)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@sobolevn@taegyunkim
pythongh-133403: CheckTools/build/generate-build-details.pywith m…
dc419f0
…ypy (python#133735)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

@sobolevnsobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@hugovk