Skip to content

gh-133741: Check strace version in support.strace_helper - #133763

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:strace_version
Closed

gh-133741: Check strace version in support.strace_helper#133763
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:strace_version

Conversation

@vstinner

@vstinnervstinner commented May 9, 2025

Copy link
Copy Markdown
Member

Need strace 5.5 or newer for the --trace option.

Need strace 5.5 or newer for the --trace option.
@vstinner
vstinner marked this pull request as ready for review May 9, 2025 14:18
@vstinnervstinner added the needs backport to 3.14 bugs and security fixes label May 9, 2025
@vstinner

Copy link
Copy Markdown
MemberAuthor

Python 3.13 test_subprocess uses a different strategy: it runs strace on the /bin/true program to check if strace works.

My PR parses the strace version from strace -V output.

@cmaloney

Copy link
Copy Markdown
Contributor

Could the version check go inside _can_strace (https://github.com/python/cpython/pull/133763/files#diff-f46934bbb48e17e6a386e49dd7375e2e5542c5d529bcadae34f3bb1e3575d3b5R203-R210). That already does a cache variable. Definitely like the approach of just disable on older strace versions.

@vstinner

Copy link
Copy Markdown
MemberAuthor

Could the version check go inside _can_strace

I wrote a simpler change: #133766

@vstinnervstinner closed this May 9, 2025
@AA-TurnerAA-Turner removed the needs backport to 3.14 bugs and security fixes label Aug 14, 2025
@vstinner
vstinner deleted the strace_version branch December 3, 2025 15:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@cmaloney@AA-Turner