Uh oh!
There was an error while loading. Please reload this page.
gh-132983: Reduce the size of _zstdmodule.h - #133793
Conversation
Uh oh!
There was an error while loading. Please reload this page.
_zstdmodule.h_zstdmodule.hhugovk
commented
May 10, 2025
Nit note about PR titles, the convention is lowercase gh-NNN for issues, and uppercase GH-NNN for PRs:
https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting
https://devguide.python.org/core-developers/committing/#backporting-changes-to-an-older-version |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
picnixz
left a comment
There was a problem hiding this comment.
It's fun that the diff for reducing the size is +165/-164.
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit 1a548c0) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-133854 is a backport of this pull request to the 3.14 branch. |
We should try and reduce the content in the header file, as it is exposed to anything that includes it.
mt_continue_should_break()moves intocompressor.cdecompress_typeenum moves intodecompressor.c#pragma once(not used for any other modules or non-vendored code) with guard definesz{std,dict}.hzstddict.hheader file to contain the definition of theZstdDictstructZstdCompressorstruct tocompressor.c(likewise for decompressor)PyModuleDef _zstdmodulestaticA