Skip to content

gh-133403: Check Tools/build/deepfreeze.py with mypy - #133802

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-133403-3
May 15, 2025
Merged

gh-133403: Check Tools/build/deepfreeze.py with mypy#133802
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-133403-3

Conversation

@sobolevn

@sobolevnsobolevn commented May 10, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@sobolevnsobolevn added the needs backport to 3.13 bugs and security fixes label May 10, 2025
@sobolevnsobolevn added the needs backport to 3.14 bugs and security fixes label May 10, 2025
@bedevere-appbedevere-appBot mentioned this pull request May 10, 2025
Closed
sobolevn
sobolevn commented May 10, 2025
View reviewed changes
Comment threadTools/build/deepfreeze.py
return self.cache[key]
self.misses += 1
if isinstance(obj, (types.CodeType, umarshal.Code)) :
if isinstance(obj, types.CodeType) :

@sobolevnsobolevnMay 10, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here umarshal.Code won't work, because generate_code requires a lot more attrs than umarshal.Code has

kumaraditya303
kumaraditya303 reviewed May 15, 2025
View reviewed changes
Comment threadTools/build/deepfreeze.py
@sobolevn
sobolevn merged commit 7eaa097 into python:mainMay 15, 2025
@miss-islington-app

miss-islington-appBot commented May 15, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2025
@sobolevn@miss-islington
pythongh-133403: CheckTools/build/deepfreeze.pywith mypy (pythonG…
0efdd27
…H-133802)
(cherry picked from commit 7eaa097)
Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app

miss-islington-appBot commented May 15, 2025

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7eaa09739059aaac4812395f8d6bb586af8eadcc 3.13

@bedevere-app

bedevere-appBot commented May 15, 2025

Copy link
Copy Markdown

GH-134038 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 15, 2025
sobolevn added a commit to sobolevn/cpython that referenced this pull request May 15, 2025
@sobolevn
[3.13]pythongh-133403: CheckTools/build/deepfreeze.pywith mypy (p…
1d04a76
…ythonGH-133802)
(cherry picked from commit 7eaa097)
Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented May 15, 2025

Copy link
Copy Markdown

GH-134040 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 15, 2025
sobolevn added a commit that referenced this pull request May 15, 2025
@miss-islington@sobolevn
[3.14]gh-133403: CheckTools/build/deepfreeze.pywith mypy (GH-133802
620065c
) (#134038)
gh-133403: Check `Tools/build/deepfreeze.py` with mypy (GH-133802)
(cherry picked from commit 7eaa097)
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request May 15, 2025
@sobolevn
[3.13]gh-133403: CheckTools/build/deepfreeze.pywith mypy (GH-133802
cec0e13
) (#134040)
(cherry picked from commit 7eaa097)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn@Pranjal095
pythongh-133403: CheckTools/build/deepfreeze.pywith mypy (python#…
be2a25c
…133802)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@sobolevn@taegyunkim
pythongh-133403: CheckTools/build/deepfreeze.pywith mypy (python#…
101c119
…133802)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

@sobolevnsobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@kumaraditya303