Skip to content

gh-132983: Remove EndlessZstdDecompressor remains - #133856

Merged
AA-Turner merged 4 commits into
python:mainfrom
Rogdham:remove-endlessdzstddecompressor-remains
May 11, 2025
Merged

gh-132983: Remove EndlessZstdDecompressor remains#133856
AA-Turner merged 4 commits into
python:mainfrom
Rogdham:remove-endlessdzstddecompressor-remains

Conversation

@Rogdham

@RogdhamRogdham commented May 10, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

cc @emmatyping@AA-Turner (can't request review)

In pyzstd there was an EndlessZstdDecompressor class implemented in the C module. Some remains of the code were left, this PR aims to remove them.

In the comments, <D> refers to ZstdDecompressor whereas <E> refers to EndlessZstdDecompressor. I cleaned that up as well.

There was _unused_char_for_align in the ZstdDecompressor struct. My understanding is that it was placed only for optimization in decompressor_reset_session when setting several attributes to 0 at once. I removed it here, but if needed I can re-add it (twice to compensate the removal of at_frame_edge).

@bedevere-appbedevere-appBot mentioned this pull request May 10, 2025
Closed
13 tasks
AA-Turner
AA-Turner reviewed May 10, 2025
View reviewed changes
Comment threadModules/_zstd/decompressor.c Outdated
Comment threadModules/_zstd/decompressor.c Outdated
Comment threadModules/_zstd/decompressor.c Outdated
Comment threadModules/_zstd/decompressor.c Outdated
Comment threadModules/_zstd/decompressor.c Outdated
Comment threadModules/_zstd/decompressor.c Outdated
Comment threadModules/_zstd/decompressor.c
Comment threadModules/_zstd/decompressor.c Outdated
AA-Turner
AA-Turner reviewed May 10, 2025
View reviewed changes
Comment threadModules/_zstd/decompressor.c Outdated
ZeroIntensity
ZeroIntensity reviewed May 10, 2025
View reviewed changes
Comment threadModules/_zstd/decompressor.c Outdated
@AA-Turner
AA-Turner enabled auto-merge (squash) May 11, 2025 01:38
@AA-Turner
AA-Turner merged commit 878e0fb into python:mainMay 11, 2025
@miss-islington-app

miss-islington-appBot commented May 11, 2025

Copy link
Copy Markdown

Thanks @Rogdham for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2025
@Rogdham@AA-Turner
@ZeroIntensity@miss-islington
pythongh-132983: Remove leftovers from EndlessZstdDecompressor (pytho…
d69fc5c
…nGH-133856)
(cherry picked from commit 878e0fb)
Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app

bedevere-appBot commented May 11, 2025

Copy link
Copy Markdown

GH-133859 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 11, 2025
AA-Turner added a commit that referenced this pull request May 11, 2025
@miss-islington@Rogdham
@AA-Turner@ZeroIntensity
[3.14]gh-132983: Remove leftovers from EndlessZstdDecompressor (GH-1…
2b761d1
…33856) (#133859)
gh-132983: Remove leftovers from EndlessZstdDecompressor (GH-133856)
(cherry picked from commit 878e0fb)
Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@Rogdham
Rogdham deleted the remove-endlessdzstddecompressor-remains branch May 11, 2025 07:03
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Rogdham@AA-Turner
@ZeroIntensity@Pranjal095
pythongh-132983: Remove leftovers from EndlessZstdDecompressor (pytho…
b011cc9
…n#133856)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Rogdham@AA-Turner
@ZeroIntensity@taegyunkim
pythongh-132983: Remove leftovers from EndlessZstdDecompressor (pytho…
bac3753
…n#133856)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes
@ZeroIntensityZeroIntensityZeroIntensity left review comments
@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rogdham@AA-Turner@ZeroIntensity