gh-133604: remove deprecated `java_ver` function by makridenko · Pull Request #133888 · python/cpython

makridenko · 2025-05-11T10:52:47Z

Issue: Remove deprecated platform.java_ver #133604

📚 Documentation preview 📚: https://cpython-previews--133888.org.readthedocs.build/

python-cla-bot · 2025-05-11T10:52:51Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2025-05-11T10:52:52Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

… in 3.15 release notes

StanFromIreland · 2025-05-11T18:33:52Z

+platform
+--------
+
+* The deprecated :func:`!platform.java_ver` function.


Suggested change
* The deprecated :func:`!platform.java_ver` function.
* Removed the deprecated :func:`!platform.java_ver` function.
To save Benedikt copy-editing it later. (See line 133)
You can also link this pr. (See line 134 as an example)

@StanFromIreland thank you! done

StanFromIreland · 2025-05-11T18:35:21Z

 #
 # <see CVS and SVN checkin messages for history>
 #
+# 1.1.0 - removed deprecated java_ver()


Not noteworthy enough IMO. These are rarely updated, but it is up to @malemburg in the end.

No need to add to that list anymore. The checkin messages provide enough history.

You may want to change # <see CVS and SVN checkin messages for history> to # <see checkin messages for history>

@malemburg thank you! done

…3.15 release notes

into fix-issue-133604

picnixz · 2025-05-16T11:25:47Z

+* Removed the deprecated :func:`!platform.java_ver` function.
+ (Contributed by Alexey Makridenko in :gh:`133888`.)


Suggested change
* Removed the deprecated :func:`!platform.java_ver` function.
(Contributed by Alexey Makridenko in :gh:`133888`.)
* Removed the :func:`!platform.java_ver` function,
which was deprecated since Python 3.13.
(Contributed by Alexey Makridenko in :gh:`133888`.)
The link should be the issue, not the PR.

thank you! fixed it

picnixz · 2025-05-16T11:27:26Z

@@ -0,0 +1 @@
+Remove deprecated function :func:`!platform.java_ver`.


Suggested change
Remove deprecated function :func:`!platform.java_ver`.
Remove :func:`!platform.java_ver` which was deprecated since Python 3.13.

thank you! fixed it

… 3.15 release notes

picnixz

Sorry to give you contradictory comments :') I didn't read the previous reviews, my bad!

malemburg

LGTM, though I haven't actually run the test suite with these changes, or built the docs.

Note: The PR branch needs to be rebased before it can be merged.

malemburg · 2025-05-16T12:39:21Z

Hmm, apparently, Github changed its mind about the need to rebase.

malemburg · 2025-05-16T12:40:40Z

@StanFromIreland Do want to review again ? Otherwise, I'll merge the PR soon.

malemburg · 2025-05-16T14:18:17Z

Thanks, @makridenko, for your work on this.

StanFromIreland · 2025-05-16T14:29:45Z

Apologies I was unavailable.

remove deprecated java_ver function and update related documentation
4f0b53e

bedevere-appBot mentioned this pull request May 11, 2025
Remove deprecated platform.java_ver#133604
Closed

bedevere-appBot added the awaiting review label May 11, 2025

makridenko added 2 commits May 11, 2025 12:57

remove deprecated java_ver function from documentation
373fe6a

deprecate platform.java_ver function for removal in Python 3.15
b50dbed

eendebakpt reviewed May 11, 2025
View reviewed changes

Comment threadDoc/whatsnew/3.13.rst

eendebakpt reviewed May 11, 2025
View reviewed changes

Comment threadDoc/whatsnew/3.15.rst Outdated

makridenko added 3 commits May 11, 2025 13:31

update formatting for deprecated platform.java_ver function section…
cbc4dd4
… in 3.15 release notes

Merge branch 'main' into fix-issue-133604
51d2061

Merge branch 'main' into fix-issue-133604
4157fa5

StanFromIreland reviewed May 11, 2025
View reviewed changes

makridenko added 3 commits May 13, 2025 14:31

update removal notice for deprecated platform.java_ver function in …
2c9d038
…3.15 release notes

Merge branch 'fix-issue-133604' ofhttps://github.com/makridenko/cpython
0139eb1
into fix-issue-133604

Merge branch 'main' into fix-issue-133604
b9f2cf6

makridenko requested review from StanFromIreland and malemburg May 14, 2025 08:29

picnixz reviewed May 16, 2025
View reviewed changes

clarify removal notice for deprecated platform.java_ver function in…
e0c4870
… 3.15 release notes

makridenko requested a review from picnixz May 16, 2025 11:48

add blank line
054efed

picnixz reviewed May 16, 2025
View reviewed changes

Comment threadDoc/whatsnew/3.15.rst Outdated

reformat removal notice
3a709ab

picnixz approved these changes May 16, 2025
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting review labels May 16, 2025

picnixz reviewed May 16, 2025
View reviewed changes

Comment threadDoc/whatsnew/3.15.rst Outdated

lint fix
d50237c

malemburg approved these changes May 16, 2025
View reviewed changes

Merge branch 'main' into fix-issue-133604
b8c57ee

malemburg merged commit 7a4a6cf into python:mainMay 16, 2025

bedevere-appBot removed the awaiting merge label May 16, 2025

picnixz mentioned this pull request Jun 14, 2025
Introduce platform.vm_info (or similar) as a replacement for recently deprecated platform.java_ver. #116504
Open

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-133604: remove deprecatedjava_verfunction (python#133888)
cfa5f13

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-133604: remove deprecatedjava_verfunction (python#133888)
fe85f53

	* The deprecated :func:`!platform.java_ver` function.
	* Removed the deprecated :func:`!platform.java_ver` function.

		* Removed the deprecated :func:`!platform.java_ver` function.
		(Contributed by Alexey Makridenko in :gh:`133888`.)

		@@ -0,0 +1 @@
		Remove deprecated function :func:`!platform.java_ver`.

	Remove deprecated function :func:`!platform.java_ver`.
	Remove :func:`!platform.java_ver` which was deprecated since Python 3.13.

Uh oh!

Uh oh!

Conversation

makridenko commented May 11, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

python-cla-botBot commented May 11, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-appBot commented May 11, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

malemburg left a comment

Choose a reason for hiding this comment

Uh oh!

malemburg commented May 16, 2025

Uh oh!

malemburg commented May 16, 2025

Uh oh!

malemburg commented May 16, 2025

Uh oh!

StanFromIreland commented May 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

makridenko commented May 11, 2025•
edited
Loading

python-cla-botBot commented May 11, 2025•
edited
Loading