Skip to content

gh-133904: math.factorial documentation fix - #133907

Merged
sobolevn merged 6 commits into
python:mainfrom
mkaraev:ghissue-133904
May 12, 2025
Merged

gh-133904: math.factorial documentation fix#133907
sobolevn merged 6 commits into
python:mainfrom
mkaraev:ghissue-133904

Conversation

@mkaraev

@mkaraevmkaraev commented May 11, 2025•
edited by ZeroIntensity
Loading

Copy link
Copy Markdown
Contributor

@python-cla-bot

python-cla-botBot commented May 11, 2025•
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news awaiting review labels May 11, 2025
@mkaraevmkaraev changed the title math.factorial documentation fixgh-133904: math.factorial documentation fixMay 11, 2025
@bedevere-appbedevere-appBot mentioned this pull request May 11, 2025
Closed
@mkaraev

mkaraev commented May 11, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@sobolevn@picnixz@skirpichev can you please review?

skirpichev
skirpichev reviewed May 11, 2025
View reviewed changes
Comment threadDoc/library/math.rst Outdated
@skirpichevskirpichev mentioned this pull request May 12, 2025
Closed
@skirpichevskirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 12, 2025
skirpichev
skirpichev reviewed May 12, 2025
View reviewed changes
Comment threadDoc/library/math.rst Outdated
sobolevn
sobolevn reviewed May 12, 2025
View reviewed changes
Comment threadModules/mathmodule.c Outdated
@skirpichev
skirpichev requested a review from sobolevnMay 12, 2025 07:43
@mkaraev

mkaraev commented May 12, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@skirpichev you added two labels about back-porting to python 3.13 and 3.14. Do I need to make similar changes to that branches too?

@skirpichev

skirpichev commented May 12, 2025

Copy link
Copy Markdown
Member

you added two labels about back-porting to python 3.13 and 3.14. Do I need to make similar changes to that branches too?

No, I think the witch will do her job this time.

sobolevn
sobolevn approved these changes May 12, 2025
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment threadDoc/library/math.rst
@sobolevn
sobolevn enabled auto-merge (squash) May 12, 2025 09:06
@sobolevn

sobolevn commented May 12, 2025

Copy link
Copy Markdown
Member

Congrats on your first CPython PR 🎉

skirpichev
skirpichev reviewed May 12, 2025
View reviewed changes
Comment threadDoc/library/math.rst Outdated
@sobolevn
sobolevn disabled auto-merge May 12, 2025 09:13
sobolevn
sobolevn reviewed May 12, 2025
View reviewed changes
Comment threadDoc/library/math.rst Outdated
@sobolevn
sobolevn enabled auto-merge (squash) May 12, 2025 09:14
@sobolevn
sobolevn merged commit 27ed645 into python:mainMay 12, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsMay 12, 2025
@miss-islington-app

miss-islington-appBot commented May 12, 2025

Copy link
Copy Markdown

Thanks @mkaraev for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@mkaraev@sobolevn@miss-islington
pythongh-133904: Fixmath.factorialdocumentation (pythonGH-133907)
43d61f9
(cherry picked from commit 27ed645)
Co-authored-by: mkaraev <maruf.karaev97@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app

miss-islington-appBot commented May 12, 2025

Copy link
Copy Markdown

Sorry, @mkaraev and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 27ed64575d34f04029ba1d353810f3db4f4f045b 3.13

@bedevere-app

bedevere-appBot commented May 12, 2025

Copy link
Copy Markdown

GH-133918 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@sobolevn

sobolevn commented May 12, 2025

Copy link
Copy Markdown
Member

@mkaraev can you please do a manual backport to 3.13? follow instructions in #133907 (comment)

@mkaraev

mkaraev commented May 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@sobolevn sure, will do

@mkaraevmkaraev mentioned this pull request May 12, 2025
Closed
@mkaraev

mkaraev commented May 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@sobolevn I tried to cherry pick manually and got some strange error.
Opened issue python/cherry-picker#159
Maybe I'm doing something wrong.

@bedevere-app

bedevere-appBot commented May 12, 2025

Copy link
Copy Markdown

GH-133922 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 12, 2025
sobolevn added a commit that referenced this pull request May 12, 2025
@mkaraev@sobolevn
[3.13]gh-133904: Fixmath.factorialdocumentation (GH-133907) (#13…
532acbd
…3922)
* [3.13] gh-133904: Fix `math.factorial` documentation (GH-133907)
(cherry picked from commit 27ed645)
Co-authored-by: mkaraev <maruf.karaev97@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request May 12, 2025
@miss-islington@mkaraev@sobolevn
[3.14]gh-133904: Fixmath.factorialdocumentation (GH-133907) (#13…
ecc12bf
…3918)
gh-133904: Fix `math.factorial` documentation (GH-133907)
(cherry picked from commit 27ed645)
Co-authored-by: mkaraev <maruf.karaev97@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@mkaraev@sobolevn@Pranjal095
pythongh-133904: Fixmath.factorialdocumentation (python#133907)
fb934a2
Co-authored-by: sobolevn <mail@sobolevn.me>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@mkaraev@sobolevn@taegyunkim
pythongh-133904: Fixmath.factorialdocumentation (python#133907)
14f3251
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichevskirpichevskirpichev approved these changes
@sobolevnsobolevnsobolevn approved these changes

Assignees

@sobolevnsobolevn

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkaraev@skirpichev@sobolevn