Skip to content

gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break() - #133947

Merged
AA-Turner merged 1 commit into
python:mainfrom
erlend-aasland:zstd-warning
May 12, 2025
Merged

gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break()#133947
AA-Turner merged 1 commit into
python:mainfrom
erlend-aasland:zstd-warning

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented May 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes the following compiler warning:

./Modules/_zstd/compressor.c:490:1: warning: unused function 'mt_continue_should_break' [-Wunused-function]
490 | mt_continue_should_break(ZSTD_inBuffer *in, ZSTD_outBuffer *out)
| ^~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

@bedevere-appbedevere-appBot mentioned this pull request May 12, 2025
Closed
13 tasks
@erlend-aasland

erlend-aasland commented May 12, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

AFAICS, mt_continue_should_break is only used in an assert, so we can safely only define it if we're debugging.

@erlend-aaslanderlend-aasland mentioned this pull request May 12, 2025
Closed
AA-Turner
AA-Turner approved these changes May 12, 2025
View reviewed changes

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see this compiler warning locally (do you need different flags for it?).

A

@AA-TurnerAA-Turner added the needs backport to 3.14 bugs and security fixes label May 12, 2025
@AA-Turner
AA-Turner merged commit 121ed71 into python:mainMay 12, 2025
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@erlend-aasland@miss-islington
pythongh-132983: Fix compiler warning about unused function ``mt_cont…
f2c2318
…inue_should_break()`` (pythonGH-133947)
(cherry picked from commit 121ed71)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app

bedevere-appBot commented May 12, 2025

Copy link
Copy Markdown

GH-133950 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@erlend-aasland
erlend-aasland deleted the zstd-warning branch May 12, 2025 19:24
AA-Turner pushed a commit that referenced this pull request May 12, 2025
@miss-islington@erlend-aasland
[3.14]gh-132983: Fix compiler warning about unused function ``mt_con…
c1aa5f8
…tinue_should_break()`` (GH-133947) (#133950)
gh-132983: Fix compiler warning about unused function ``mt_continue_should_break()`` (GH-133947)
(cherry picked from commit 121ed71)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@erlend-aasland@Pranjal095
pythongh-132983: Fix compiler warning about unused function ``mt_cont…
d53338e
…inue_should_break()`` (python#133947)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@erlend-aasland@taegyunkim
pythongh-132983: Fix compiler warning about unused function ``mt_cont…
fef033c
…inue_should_break()`` (python#133947)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes
@emmatypingemmatypingemmatyping approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland@AA-Turner@emmatyping