Uh oh!
There was an error while loading. Please reload this page.
gh-134939: Add the interpreters Module - #133958
Conversation
7ddfb50 to
5c8545aComparebedevere-bot
commented
May 27, 2025
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5c8545a 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
1e34abd to
c63b6bcComparebedevere-bot
commented
May 29, 2025
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit c63b6bc 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
c63b6bc to
ea9041cCompareericsnowcurrently
commented
May 30, 2025
FTR, I ran this against the buildbots and there were two failures:
Neither looks related, but I'll rerun them just to be sure. |
ea9041c to
0a5d0e4Compareericsnowcurrently
commented
May 30, 2025
!buildbot aarch64 RHEL8 Refleaks |
bedevere-bot
commented
May 30, 2025
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0a5d0e4 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
ericsnowcurrently
commented
May 30, 2025
!buildbot wasm32-wasi Non-Debug |
bedevere-bot
commented
May 30, 2025
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0a5d0e4 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
| if name in ('Queue', 'QueueEmpty', 'QueueFull', 'create_queue'): | ||
| global create_queue, Queue, QueueEmpty, QueueFull | ||
| ns = globals() | ||
| from .queues import ( | ||
| from ._queues import ( | ||
| create as create_queue, | ||
| Queue, QueueEmpty, QueueFull, | ||
| ) |
There was a problem hiding this comment.
Is importing the interpreters.queues modules expensive enough to warrant the complexity of delayed imports & module-level __getattr__? If it is, we should also implement module-level __dir__.
If not though, I'd suggest just simplifying all of this into a regular import.
There was a problem hiding this comment.
Yeah, it might not matter so much. I'll take a look at dropping the module __getattr__.
ericsnowcurrently
commented
Jun 6, 2025
!buildbot PPC64LE RHEL8 LTO + PGO |
bedevere-bot
commented
Jun 6, 2025
The regex 'PPC64LE RHEL8 LTO + PGO' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
ericsnowcurrently
commented
Jun 6, 2025
!buildbot PPC64LE RHEL8 LTO + PGO |
bedevere-bot
commented
Jun 6, 2025
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit e4cbc66 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
ericsnowcurrently
commented
Jun 6, 2025
I'll merge this once I've verified that buildbot passes. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| try: | ||
| from test.support import interpreters | ||
| from concurrent import interpreters | ||
| except ImportError: | ||
| interpreters = None |
There was a problem hiding this comment.
Do we have a reason to expect this import will fail, or can we remove this condition? (Here and elsewhere.)
There was a problem hiding this comment.
Probably if _interpreters doesn't exist.
There was a problem hiding this comment.
Currently the module isn't supported on WASI and Emscripten builds. See gh-135190.
There was a problem hiding this comment.
And I've been waiting for Eric to try to turn it all on -- at least for WASI -- and see if it just works. 😉
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ericsnowcurrently
commented
Jun 11, 2025
I'll merge this in a couple hours unless I hear any objections. |
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, @ericsnowcurrently, I could not cleanly backport this to |
serhiy-storchaka
commented
Aug 14, 2025
Reminder about backporting. @ericsnowcurrently |
AA-Turner
commented
Aug 14, 2025
@serhiy-storchaka the A |
serhiy-storchaka
commented
Aug 14, 2025
Labels were not updated. |
This is in case PEP-734 is accepted.