Skip to content

gh-115119: Removed bundled copy of the libmpdec - #133964

Merged
zware merged 38 commits into
python:mainfrom
skirpichev:remove-bundled-mpdecimal/115119
May 12, 2026
Merged

gh-115119: Removed bundled copy of the libmpdec#133964
zware merged 38 commits into
python:mainfrom
skirpichev:remove-bundled-mpdecimal/115119

Conversation

@skirpichev

@skirpichevskirpichev commented May 13, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 13, 2025
Closed
15 tasks
@skirpichev
skirpichevforce-pushed the remove-bundled-mpdecimal/115119 branch from 7cba56a to 9d6c9b5CompareMay 13, 2025 15:37
AA-Turner
AA-Turner reviewed May 13, 2025
View reviewed changes

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick comments, haven't looked at build system changes

Comment threadDoc/using/configure.rst
Comment threadDoc/whatsnew/3.13.rst Outdated
Comment threadDoc/whatsnew/3.15.rst Outdated
Comment threadMisc/sbom.spdx.json Outdated
Comment threadModules/Setup.stdlib.in Outdated
skirpichevand others added 2 commits May 13, 2025 19:21
@skirpichev@AA-Turner
Apply suggestions from code review
5de2aa2
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@skirpichev
+ configure
dfd9f40
zware
zware previously requested changes May 13, 2025
View reviewed changes
Comment threadPCbuild/_decimal.vcxproj.filters
@bedevere-app

This comment was marked as resolved.

Sign in to view
@AA-Turner

This comment was marked as resolved.

Sign in to view
@skirpichev

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app
bedevere-appBot requested a review from zwareMay 14, 2025 03:41
@skirpichev

This comment was marked as resolved.

Sign in to view
@skirpichev
skirpichevforce-pushed the remove-bundled-mpdecimal/115119 branch from 0a33f9f to 2ba6b8bCompareMay 14, 2025 05:49
@skirpichev
skirpichev requested a review from zwareMay 9, 2026 05:59
sethmlarson
sethmlarson approved these changes May 11, 2026
View reviewed changes

@sethmlarsonsethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes to sbom.spdx.json and generate_sbom.py and those changes LGTM.

zware
zware reviewed May 11, 2026
View reviewed changes

@zwarezware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite close, I think, just a few more cleanups.

Comment threadDoc/license.rst
Comment threadDoc/tools/removed-ids.txt
Comment threadDoc/whatsnew/3.16.rst Outdated
Comment threadModules/_decimal/README.txt
Comment threadconfigure.ac Outdated
Comment threadModules/_decimal/README.txt
@skirpichev
skirpichev requested a review from zwareMay 12, 2026 04:07
zware
zware reviewed May 12, 2026
View reviewed changes
Comment threadDoc/whatsnew/3.16.rst
Comment threadDoc/license.rst Outdated
Comment on lines 962 to 964
Previously, the :mod:`!_decimal` C extension underlying the :mod:`decimal` module
was built using an included copy of the libmpdec
library unless the build is configured ``--with-system-libmpdec``::

@zwarezwareMay 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't hurt to fix the libffi section as well. Suggested wording here, though:

Suggested change
Previously, the :mod:`!_decimal` C extension underlying the :mod:`decimal` module
was built using an included copy of the libmpdec
library unless the build is configured ``--with-system-libmpdec``::
The :mod:`!_decimal` C extension underlying the :mod:`decimal` module
is linked to the libmpdec C library::

On the other hand, we could just leave this file alone for now and get someone more knowledgeable about such things to tell us what we should do in a separate issue :)

@skirpichevskirpichevMay 12, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then lets keep this intact.

Comment threadconfigure.ac Outdated
Comment threadconfigure.ac
# Disable forced inlining in debug builds, see GH-94847
AS_VAR_IF(
[with_pydebug], [yes],
[AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -DTEST_COVERAGE"])])

@zwarezwareMay 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only relevant for building libmpdec itself, isn't it?

There is a usage of TEST_COVERAGE in Modules/_decimal/_decimal.c, but I don't see anything ever defining it for that module.

@skirpichevskirpichevMay 12, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a usage of TEST_COVERAGE in Modules/_decimal/_decimal.c, but I don't see anything ever defining it for that module.

It's defined there, no?

@zwarezwareMay 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sorry, my understanding of how LIBMPDEC_{CFLAGS,LDFLAGS} work was incorrect; this is fine.

@skirpichevskirpichevMay 13, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this define used only in one place, we could replace it with Py_DEBUG in the code.

Comment threadconfigure.ac Outdated
Comment threadModules/_decimal/README.txt
@skirpichev
skirpichev requested a review from zwareMay 12, 2026 20:18
zware
zware reviewed May 12, 2026
View reviewed changes
Comment threadDoc/whatsnew/3.13.rst Outdated
Comment threadDoc/license.rst Outdated
@zware
Apply suggestions from code review
b4cc60d
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
@zware
zware enabled auto-merge (squash) May 12, 2026 21:08
@zware
zware merged commit 9eb3b14 into python:mainMay 12, 2026
69 checks passed
@skirpichev
skirpichev deleted the remove-bundled-mpdecimal/115119 branch May 13, 2026 01:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deilyned-deilyned-deily left review comments
@zwarezwarezware approved these changes
@sethmlarsonsethmlarsonsethmlarson approved these changes
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner
@StanFromIrelandStanFromIrelandAwaiting requested review from StanFromIreland
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner
@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner
@corona10corona10Awaiting requested review from corona10corona10 is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@webknjazwebknjazAwaiting requested review from webknjazwebknjaz is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@skirpichev@AA-Turner@ned-deily@zware@sethmlarson@StanFromIreland