Uh oh!
There was an error while loading. Please reload this page.
gh-132124: improve safety nets for creating AF_UNIX socket files - #134085
Merged
gpshead merged 4 commits intoMay 21, 2025
Conversation
gpshead
approved these changes
May 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
gpshead
requested changes
May 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
When you're done making the requested changes, leave the comment: |
picnixzforce-pushed
the
fix/multiprocessing/temp-dir-132124
branch
from
May 17, 2025 10:18
3233fdc to
84f7020Comparepicnixz
commented
May 17, 2025
MemberAuthor
I have made the requested changes; please review again. |
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
thesamesam
commented
May 17, 2025
Contributor
Thank you! It works (and the change seems to have the semantics I'd expect). |
gpshead
approved these changes
May 21, 2025
| __all__ = [ | ||
| 'sub_debug', 'debug', 'info', 'sub_warning', 'get_logger', | ||
| 'sub_debug', 'debug', 'info', 'sub_warning', 'warn', 'get_logger', |
Member
There was a problem hiding this comment.
note to self: I'm going to leave 'warn' out of __all__ and rename the function to _warn as a modification to our 3.13 backport as it'd technically be an API change in a bugfix release otherwise.
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2025
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used (cherry picked from commit 1a07a01) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-134447 is a backport of this pull request to the 3.14 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2025
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used (cherry picked from commit 1a07a01) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-134448 is a backport of this pull request to the 3.13 branch. |
gpshead pushed a commit
that referenced
this pull request
May 21, 2025
…es (GH-134085) (#134447) gh-132124: improve safety nets for creating AF_UNIX socket files (GH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used (cherry picked from commit 1a07a01) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
lkollar pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used
Pranjal095 pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used
gpshead added a commit
that referenced
this pull request
Aug 4, 2025
…es (GH-134085) (#134448) * gh-132124: improve safety nets for creating AF_UNIX socket files (GH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used (cherry picked from commit 1a07a01) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> * rename warn -> _warn for the 3.13.x backport * Update Misc/NEWS.d/next/Library/2025-05-16-12-40-37.gh-issue-132124.T_5Odx.rst --------- Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
taegyunkim pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used
zmedico
reviewed
Oct 29, 2025
| # [2]: https://man7.org/linux/man-pages/man7/unix.7.html. | ||
| if sys.platform == 'linux': | ||
| _SUN_PATH_MAX = 108 |
There was a problem hiding this comment.
This _SUN_PATH_MAX = 108 value for Linux includes a null terminator, resulting in #140734.
gostak-dd pushed a commit
to gostak-dd/cpython
that referenced
this pull request
Jun 2, 2026
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Poupine@thesamesam@mmokrejs
multiprocessing.util.get_temp_dir()can be used to create socket files with limited path length #132124