Skip to content

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task - #134202

Merged
gvanrossum merged 6 commits into
python:mainfrom
graingert:doc-new-asyncio-create-task-kwargs
May 22, 2025
Merged

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task#134202
gvanrossum merged 6 commits into
python:mainfrom
graingert:doc-new-asyncio-create-task-kwargs

Conversation

@graingert

@graingertgraingert commented May 19, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request May 19, 2025
Closed
@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news labels May 19, 2025
graingert
graingert commented May 19, 2025
View reviewed changes
Comment threadDoc/library/asyncio-eventloop.rst Outdated
graingert
graingert commented May 19, 2025
View reviewed changes
Comment threadDoc/library/asyncio-eventloop.rst
graingert
graingert commented May 19, 2025
View reviewed changes
Comment threadDoc/library/asyncio-task.rst Outdated
gvanrossum
gvanrossum reviewed May 20, 2025
View reviewed changes
Comment threadDoc/library/asyncio-eventloop.rst
@gvanrossumgvanrossum mentioned this pull request May 20, 2025
Merged
@graingert
graingert marked this pull request as ready for review May 20, 2025 06:54
gvanrossum
gvanrossum reviewed May 20, 2025
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I'm uneasy with how name, context and eager_task arguments are presented.

Comment threadDoc/library/asyncio-eventloop.rst
@gvanrossum

gvanrossum commented May 20, 2025

Copy link
Copy Markdown
Member

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

@graingert

graingert commented May 20, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

I thought we were happy with the docs on 3.13 now? So this won't need a backport

@gvanrossum

gvanrossum commented May 20, 2025

Copy link
Copy Markdown
Member

I thought we were happy with the docs on 3.13 now? So this won't need a backport

Agreed, not to 3.13. But this should be marked as backport to 3.14 right?

What do you think about my comment on the signature description?

@gvanrossumgvanrossum added the needs backport to 3.14 bugs and security fixes label May 20, 2025
gvanrossum
gvanrossum approved these changes May 22, 2025
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG then! I will merge and ensure a backport to 3.14 happens.

@gvanrossumgvanrossum changed the title gh-128307: update docs to TaskGroup.create_task and asyncio.create_taskgh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_taskMay 22, 2025
@gvanrossum
gvanrossum merged commit a3d0306 into python:mainMay 22, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsMay 22, 2025
@miss-islington-app

miss-islington-appBot commented May 22, 2025

Copy link
Copy Markdown

Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2025
@graingert@miss-islington
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
cd5c579
…e_task, asyncio.create_task (pythonGH-134202)
(cherry picked from commit a3d0306)
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-app

bedevere-appBot commented May 22, 2025

Copy link
Copy Markdown

GH-134553 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 22, 2025
kumaraditya303 pushed a commit that referenced this pull request May 23, 2025
@miss-islington@graingert
[3.14]gh-128307: Update docs for asyncio.create_task, TaskGroup.crea…
1cdbb33
…te_task, asyncio.create_task (GH-134202) (#134553)
gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task (GH-134202)
(cherry picked from commit a3d0306)
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@graingert@Pranjal095
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
2cfbdab
…e_task, asyncio.create_task (python#134202)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@graingert@taegyunkim
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
c2dab71
…e_task, asyncio.create_task (python#134202)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@graingert@gostak-dd
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
e7f23d0
…e_task, asyncio.create_task (python#134202)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@graingert@gvanrossum@kumaraditya303