Skip to content

gh-129748: Update mimalloc to use atomic store for mi_block_set_nextx - #134238

Merged
corona10 merged 1 commit into
python:mainfrom
corona10:gh-129748
May 20, 2025
Merged

gh-129748: Update mimalloc to use atomic store for mi_block_set_nextx#134238
corona10 merged 1 commit into
python:mainfrom
corona10:gh-129748

Conversation

@corona10

@corona10corona10 commented May 19, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 19, 2025
Closed
@corona10
corona10 requested a review from colesburyMay 19, 2025 15:02
@corona10corona10 added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 19, 2025
@corona10
corona10 marked this pull request as ready for review May 19, 2025 19:24
@corona10
corona10 requested a review from Yhg1sMay 19, 2025 19:25
@corona10

corona10 commented May 19, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Following code is now fully okay with this PR.

https://gist.github.com/duaneg/59ec54d52e19a7ad52d8c4d82ef8e9fb

colesbury
colesbury approved these changes May 20, 2025
View reviewed changes

@colesburycolesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@corona10
corona10 merged commit 317c496 into python:mainMay 20, 2025
@miss-islington-app

miss-islington-appBot commented May 20, 2025

Copy link
Copy Markdown

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@corona10@miss-islington
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
e624962
…_nextx (pythonGH-134238)
(cherry picked from commit 317c496)
Co-authored-by: Donghee Na <donghee.na@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@corona10@miss-islington
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
931bec7
…_nextx (pythonGH-134238)
(cherry picked from commit 317c496)
Co-authored-by: Donghee Na <donghee.na@python.org>
@bedevere-app

bedevere-appBot commented May 20, 2025

Copy link
Copy Markdown

GH-134352 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
@bedevere-app

bedevere-appBot commented May 20, 2025

Copy link
Copy Markdown

GH-134353 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 20, 2025
corona10 added a commit that referenced this pull request May 20, 2025
@miss-islington@corona10
[3.14]gh-129748: Update mimalloc to use atomic store for mi_block_se…
dc5866a
…t_nextx (GH-134238) (gh-134352)
gh-129748: Update mimalloc to use atomic store for mi_block_set_nextx (GH-134238)
(cherry picked from commit 317c496)
Co-authored-by: Donghee Na <donghee.na@python.org>
corona10 added a commit that referenced this pull request May 20, 2025
@miss-islington@corona10
[3.13]gh-129748: Update mimalloc to use atomic store for mi_block_se…
bad9f63
…t_nextx (GH-134238) (gh-134353)
gh-129748: Update mimalloc to use atomic store for mi_block_set_nextx (GH-134238)
(cherry picked from commit 317c496)
Co-authored-by: Donghee Na <donghee.na@python.org>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@corona10@lkollar
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
718505c
…_nextx (python#134238)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@corona10@Pranjal095
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
14fce87
…_nextx (python#134238)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@corona10@taegyunkim
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
bf49758
…_nextx (python#134238)
colesbury added a commit that referenced this pull request Dec 17, 2025
@colesbury
gh-129748: Remove TSan suppression for mi_block_set_nextx (gh-142887)
6e625f8
The function was already changed to use a relaxed atomic store in gh-134238.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes
@Yhg1sYhg1sAwaiting requested review from Yhg1s

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corona10@colesbury