Skip to content

gh-131798: Split CALL_LIST_APPEND into serveral uops - #134240

Merged
diegorusso merged 6 commits into
python:mainfrom
diegorusso:call_list_append
May 19, 2025
Merged

gh-131798: Split CALL_LIST_APPEND into serveral uops#134240
diegorusso merged 6 commits into
python:mainfrom
diegorusso:call_list_append

Conversation

@diegorusso

@diegorussodiegorusso commented May 19, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@diegorussodiegorusso changed the title gh-133180: Optimize _CALL_LIST_APPENDgh-131798: Optimize _CALL_LIST_APPENDMay 19, 2025
@bedevere-appbedevere-appBot mentioned this pull request May 19, 2025
Open
Fidget-Spinner
Fidget-Spinner reviewed May 19, 2025
View reviewed changes
Comment threadPython/bytecodes.c
@diegorussodiegorusso changed the title gh-131798: Optimize _CALL_LIST_APPENDgh-131798: Split CALL_LIST_APPEND into serveral uopsMay 19, 2025
brandtbucher
brandtbucher approved these changes May 19, 2025
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing:

Comment threadPython/bytecodes.c Outdated
@diegorusso

diegorusso commented May 19, 2025

Copy link
Copy Markdown
ContributorAuthor

The failures on macOS will be fixed by: #134224
The Windows error is being worked by @brandtbucher and pushed soon.

@diegorusso
diegorusso merged commit 42d03f3 into python:mainMay 19, 2025
@diegorusso
diegorusso deleted the call_list_append branch May 19, 2025 19:49
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@diegorusso@Pranjal095
pythonGH-131798: Split CALL_LIST_APPEND into several uops (pythonGH-1…
1699e48
…34240)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@diegorusso@taegyunkim
pythonGH-131798: Split CALL_LIST_APPEND into several uops (pythonGH-1…
7e8cdc1
…34240)
@efimov-mikhailefimov-mikhail mentioned this pull request Nov 11, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner left review comments
@brandtbucherbrandtbucherbrandtbucher approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diegorusso@Fidget-Spinner@brandtbucher