gh-133579: correctly report C curses errors in _curses_panel

[picnixz]

This was part of #125844 but I extracted it from there because it wasn't necessary. I'll make it part of gh-133579 instead of gh-125843 because the other one was more for curses module itself and this one is a follow-up (and also because I changed some exception types)

• Issue: Exact reporting of curses C function failures #133579

[encukou]

Looks good! Sorry for the delay.
Let's merge if the buildbots don't complain.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @encukou for commit e6c00d0 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134629%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[encukou]

Buildbot failures are unrelated.
I don't mind keeping the comment in. Do you really want to remove it?

[picnixz]

Do you really want to remove it?

Not really, though I think I can remove it if we go through all modules that don't correctly assert this (but in a follow-up). In practice, I don't think it'll be an issue as such functions are internal-only, so issues would be caught at review time. We could do more expensive checks on DEBUG builds though.

I think I wanted to remove it because I expected that this issue was already well-known and that my comment could have been "too much".

[encukou]

So let's merge this as is?
(You just assigned yourself, does that mean you want to do something more?)

[picnixz]

(You just assigned yourself, does that mean you want to do something more?)

I assign the PR to myself when I want to merge it later, otherwise I forget about the PR. But if you want to merge it before, you can go ahead!

[picnixz]

Also, I myself only merge stuff when I'm on Linux as I can revert or make a fast patch if something breaks just after (I'm currently on Windows since I'm playing). So usually I merge my PRs when I'm back on Linux.

[encukou]

I assign the PR to myself when I want to merge it later, otherwise I forget about the PR.

Ah, got it! I'll try to remember that for later :)

Also, I myself only merge stuff when I'm on Linux as I can revert or make a fast patch if something breaks just after (I'm currently on Windows since I'm playing).

No rush. Myself, I'm only back to Linux now.
(Feel free to turn off GitHub notifications when playing; it's perfectly OK to reply a day or two later.)