Skip to content

gh-134160: Block multiple module initialization - #134773

Merged
AA-Turner merged 4 commits into
python:mainfrom
encukou:extending-exec-once
May 28, 2025
Merged

gh-134160: Block multiple module initialization#134773
AA-Turner merged 4 commits into
python:mainfrom
encukou:extending-exec-once

Conversation

@encukou

@encukouencukou commented May 27, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Change the tutorial to block multiple module initialization, and note the reference leak.

📚 Documentation preview 📚: https://cpython-previews--134773.org.readthedocs.build/

@bedevere-appbedevere-appBot mentioned this pull request May 27, 2025
Open
@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news labels May 27, 2025
@encukou

encukou commented May 27, 2025

Copy link
Copy Markdown
MemberAuthor

There's a better way to do this, but module state might work better in Chapter 2?

neonene
neonene reviewed May 27, 2025
View reviewed changes
Comment threadDoc/extending/extending.rst Outdated
ZeroIntensity
ZeroIntensity reviewed May 27, 2025
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that we don't have any dedicated section on subinterpreters. I'd be happy to do that in a follow-up.

Comment threadDoc/extending/extending.rst Outdated
StanFromIreland
StanFromIreland reviewed May 27, 2025
View reviewed changes
Comment threadDoc/extending/extending.rst
encukouand others added 2 commits May 27, 2025 17:38
AA-Turner
AA-Turner reviewed May 27, 2025
View reviewed changes
Comment threadDoc/extending/extending.rst Outdated
AA-Turner
AA-Turner reviewed May 27, 2025
View reviewed changes
Comment threadDoc/extending/extending.rst
AA-Turner
AA-Turner approved these changes May 27, 2025
View reviewed changes

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor suggestions, but otherwise let's get this merged quickly.

A

@AA-TurnerAA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 27, 2025
@encukou@AA-Turner
Apply suggestions from code review
c562e2e
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-Turner
AA-Turner merged commit 469a564 into python:mainMay 28, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsMay 28, 2025
@miss-islington-app

miss-islington-appBot commented May 28, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
@encukou@AA-Turner@miss-islington
pythongh-134160: Block multiple module initialization (pythonGH-134773)
bd36c93
(cherry picked from commit 469a564)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
@encukou@AA-Turner@miss-islington
pythongh-134160: Block multiple module initialization (pythonGH-134773)
6d5c370
(cherry picked from commit 469a564)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented May 28, 2025

Copy link
Copy Markdown

GH-134827 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 28, 2025
@bedevere-app

bedevere-appBot commented May 28, 2025

Copy link
Copy Markdown

GH-134828 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 28, 2025
@encukou
encukou deleted the extending-exec-once branch May 28, 2025 07:56
AA-Turner added a commit that referenced this pull request May 28, 2025
@miss-islington@encukou@AA-Turner
[3.14]gh-134160: Block multiple module initialization (GH-134773) (#…
998cedb
…134827)
gh-134160: Block multiple module initialization (GH-134773)
(cherry picked from commit 469a564)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request May 28, 2025
@miss-islington@encukou@AA-Turner
[3.13]gh-134160: Block multiple module initialization (GH-134773) (#…
067df2b
…134828)
gh-134160: Block multiple module initialization (GH-134773)
(cherry picked from commit 469a564)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou@AA-Turner@Pranjal095
pythongh-134160: Block multiple module initialization (python#134773)
6adbe96
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou@AA-Turner@taegyunkim
pythongh-134160: Block multiple module initialization (python#134773)
e8d345a
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@encukou@AA-Turner@gostak-dd
pythongh-134160: Block multiple module initialization (python#134773)
b49a480
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments
@StanFromIrelandStanFromIrelandStanFromIreland left review comments
@AA-TurnerAA-TurnerAA-Turner approved these changes
+1 more reviewer
@neoneneneoneneneonene left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@encukou@AA-Turner@ZeroIntensity@neonene@StanFromIreland