Skip to content

gh-131876: extract _hashlib helpers into a separate directory [WIP] - #135341

Closed
picnixz wants to merge 15 commits into
python:mainfrom
picnixz:refactor/hashlib/lookup-md-131876
Closed

gh-131876: extract _hashlib helpers into a separate directory [WIP]#135341
picnixz wants to merge 15 commits into
python:mainfrom
picnixz:refactor/hashlib/lookup-md-131876

Conversation

@picnixz

@picnixzpicnixz commented Jun 10, 2025

Copy link
Copy Markdown
Member

@picnixz

Copy link
Copy Markdown
MemberAuthor

!buildbot FIPS only

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit c90722e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135341%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

@picnixz
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch from cb8ac17 to b213a79CompareJune 10, 2025 11:32
@picnixz

Copy link
Copy Markdown
MemberAuthor

Ok. This is too messy. I'll need to think about it differently.

@picnixz
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch 6 times, most recently from 11b0d3c to 0692cccCompareJune 10, 2025 13:05
@picnixz

picnixz commented Jun 10, 2025

Copy link
Copy Markdown
MemberAuthor

Ok, for now it seems to work on Linux/macOS. Still need to figure out why it fails on WASI and Windows but I have my little idea.

Comment threadPCbuild/_hashlib.vcxproj.filters Outdated
@picnixz
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch 2 times, most recently from 28067ff to 5f21471CompareJune 14, 2025 11:35
@picnixz
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch from 5f21471 to e705d15CompareJune 14, 2025 11:37
@picnixz
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch 2 times, most recently from 1cb7edb to 3dd0a97CompareJune 14, 2025 12:08
@picnixz

Copy link
Copy Markdown
MemberAuthor

Ok WASI moments. But Windows works!

@picnixz
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch from 1eeae0a to 972a185CompareJuly 22, 2025 11:39
@picnixz

Copy link
Copy Markdown
MemberAuthor

I'm done with my experiments, I'll create a fresh PR to have better commits.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@bedevere-bot