Skip to content

gh-135429: Fix the argument mismatch in lsprof throw event - #135442

Merged
gaogaotiantian merged 3 commits into
python:mainfrom
gaogaotiantian:fix-lsprof-throw-event
Jun 12, 2025
Merged

gh-135429: Fix the argument mismatch in lsprof throw event#135442
gaogaotiantian merged 3 commits into
python:mainfrom
gaogaotiantian:fix-lsprof-throw-event

Conversation

@gaogaotiantian

@gaogaotiantiangaogaotiantian commented Jun 12, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

PY_THROW event has a different signature than PY_START. We changed the interface to argument clinic and ignored the difference. It would've been caught but the test case was changed from another PR.

This PR fixes the issue and refreshes the testcase.

@bedevere-appbedevere-appBot mentioned this pull request Jun 12, 2025
Closed
@gaogaotiantiangaogaotiantian added the needs backport to 3.14 bugs and security fixes label Jun 12, 2025
ZeroIntensity
ZeroIntensity approved these changes Jun 12, 2025
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

Comment threadMisc/NEWS.d/next/Library/2025-06-12-18-15-31.gh-issue-135429.mch75_.rst Outdated
@gaogaotiantian@ZeroIntensity
Update Misc/NEWS.d/next/Library/2025-06-12-18-15-31.gh-issue-135429.m…
893c9bf
…ch75_.rst
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@gaogaotiantian
gaogaotiantian merged commit b03309f into python:mainJun 12, 2025
@miss-islington-app

miss-islington-appBot commented Jun 12, 2025

Copy link
Copy Markdown

Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@gaogaotiantian
gaogaotiantian deleted the fix-lsprof-throw-event branch June 12, 2025 21:46
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2025
@gaogaotiantian@miss-islington
pythongh-135429: Fix the argument mismatch in lsprof throw event (pyt…
dff154f
…honGH-135442)
(cherry picked from commit b03309f)
Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app

bedevere-appBot commented Jun 12, 2025

Copy link
Copy Markdown

GH-135446 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jun 12, 2025
gaogaotiantian added a commit that referenced this pull request Jun 12, 2025
@miss-islington@gaogaotiantian
[3.14]gh-135429: Fix the argument mismatch in lsprof throw event (GH…
f885c7d
…-135442) (#135446)
gh-135429: Fix the argument mismatch in lsprof throw event (GH-135442)
(cherry picked from commit b03309f)
Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@gaogaotiantian@lkollar
pythongh-135429: Fix the argument mismatch in lsprof throw event (pyt…
5ad8eb5
…hon#135442)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@gaogaotiantian@Pranjal095
pythongh-135429: Fix the argument mismatch in lsprof throw event (pyt…
2a118af
…hon#135442)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@gaogaotiantian@taegyunkim
pythongh-135429: Fix the argument mismatch in lsprof throw event (pyt…
14454e9
…hon#135442)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@gaogaotiantian@Agent-Hellboy
pythongh-135429: Fix the argument mismatch in lsprof throw event (pyt…
cf6b5ec
…hon#135442)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes
@ZeroIntensityZeroIntensityZeroIntensity approved these changes
@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaogaotiantian@iritkatriel@ZeroIntensity