Skip to content

gh-111178: fix UBSan failures for RemoteUnwinderObject - #135539

Merged
pablogsal merged 1 commit into
python:mainfrom
picnixz:fix/ubsan/remote-inspection-111178
Jun 15, 2025
Merged

gh-111178: fix UBSan failures for RemoteUnwinderObject#135539
pablogsal merged 1 commit into
python:mainfrom
picnixz:fix/ubsan/remote-inspection-111178

Conversation

@picnixz

@picnixzpicnixz commented Jun 15, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This fixes the following

./python -m test test_external_inspection
...
Objects/object.c:3195:5: runtime error: call to function RemoteUnwinder_dealloc through pointer to incorrect function type 'void (*)(struct _object *)'
/home/picnix/lib/python/cpython/./Modules/_remote_debugging_module.c:2903: note: RemoteUnwinder_dealloc defined here

@bedevere-appbedevere-appBot mentioned this pull request Jun 15, 2025
Closed
@pablogsal
pablogsal merged commit 54e29ea into python:mainJun 15, 2025
@pablogsal

pablogsal commented Jun 15, 2025

Copy link
Copy Markdown
Member

Thanks 🙏

@picnixz

picnixz commented Jun 15, 2025

Copy link
Copy Markdown
MemberAuthor

You're welcome. We can backport this if you want but I don't know which versions are affected (I am not on my dev session)

@picnixz
picnixz deleted the fix/ubsan/remote-inspection-111178 branch June 15, 2025 19:01
@pablogsalpablogsal added the needs backport to 3.14 bugs and security fixes label Jun 15, 2025
@miss-islington-app

miss-islington-appBot commented Jun 15, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2025
@picnixz@miss-islington
pythongh-111178: fix UBSan failures forRemoteUnwinderObject(pytho…
414fc25
…nGH-135539)
(cherry picked from commit 54e29ea)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@pablogsal

pablogsal commented Jun 15, 2025

Copy link
Copy Markdown
Member

Yeah let's backport for sure

@bedevere-app

bedevere-appBot commented Jun 15, 2025

Copy link
Copy Markdown

GH-135547 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jun 15, 2025
pablogsal pushed a commit that referenced this pull request Jun 15, 2025
@miss-islington
[3.14]gh-111178: fix UBSan failures forRemoteUnwinderObject(GH-1…
e89c7f1
…35539) (#135547)
shuimu5418 pushed a commit to shuimu5418/cpython001 that referenced this pull request Jun 16, 2025
@picnixz@shuimu5418
pythongh-111178: fix UBSan failures forRemoteUnwinderObject(pytho…
34e85c3
…n#135539)
encukou added a commit to encukou/cpython that referenced this pull request Jun 17, 2025
@encukou
Revert "pythongh-111178: fix UBSan failures forRemoteUnwinderObject(
203c517
python#135539)"
This reverts commit 54e29ea.
encukou added a commit to encukou/cpython that referenced this pull request Jun 17, 2025
@encukou
Revert "pythongh-111178: fix UBSan failures forRemoteUnwinderObject(
046a401
python#135539)"
This reverts commit 54e29ea.
encukou added a commit to encukou/cpython that referenced this pull request Jun 17, 2025
@encukou
Revert "pythongh-111178: fix UBSan failures forRemoteUnwinderObject(
4048a40
python#135539)"
This reverts commit 54e29ea.
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@picnixz@lkollar
pythongh-111178: fix UBSan failures forRemoteUnwinderObject(pytho…
e37883a
…n#135539)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz@Pranjal095
pythongh-111178: fix UBSan failures forRemoteUnwinderObject(pytho…
e4d0105
…n#135539)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz@taegyunkim
pythongh-111178: fix UBSan failures forRemoteUnwinderObject(pytho…
4110c0f
…n#135539)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@picnixz@Agent-Hellboy
pythongh-111178: fix UBSan failures forRemoteUnwinderObject(pytho…
75d0d57
…n#135539)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes
@ambvambvAwaiting requested review from ambv
@1st11st1Awaiting requested review from 1st1

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@pablogsal