Skip to content

gh-135755: Move PyFunction_GET_BUILTINS to the private API - #135938

Merged
encukou merged 1 commit into
python:mainfrom
ZeroIntensity:private-get-builtins
Jun 26, 2025
Merged

gh-135755: Move PyFunction_GET_BUILTINS to the private API#135938
encukou merged 1 commit into
python:mainfrom
ZeroIntensity:private-get-builtins

Conversation

@ZeroIntensity

@ZeroIntensityZeroIntensity commented Jun 25, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This is an alternative to GH-135934. It seems like it might be better to move this to the private API for a few reasons:

  1. There's no PyFunction_Get* equivalent for PyFunction_GET_BUILTINS.
  2. It's mostly untested, the only reference to it in the tests being in _testinternalcapi.

@bedevere-appbedevere-appBot mentioned this pull request Jun 25, 2025
Closed
39 tasks
ericsnowcurrently
ericsnowcurrently approved these changes Jun 25, 2025
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, making it internal makes sense.

encukou
encukou approved these changes Jun 26, 2025
View reviewed changes

@encukouencukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukou
encukou merged commit 10a3d43 into python:mainJun 26, 2025
51 checks passed
@miss-islington-app

miss-islington-appBot commented Jun 26, 2025

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
@ZeroIntensity@miss-islington
pythongh-135755: MovePyFunction_GET_BUILTINSto the private API (p…
e582c8b
…ythonGH-135938)
(cherry picked from commit 10a3d43)
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app

bedevere-appBot commented Jun 26, 2025

Copy link
Copy Markdown

GH-135972 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
@encukouencukou mentioned this pull request Jun 26, 2025
Closed
encukou pushed a commit that referenced this pull request Jun 26, 2025
@miss-islington@ZeroIntensity
[3.14]gh-135755: MovePyFunction_GET_BUILTINSto the private API (G…
a797fe1
…H-135938) (GH-135972)
(cherry picked from commit 10a3d43)
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@ZeroIntensity@AndPuQing
pythongh-135755: MovePyFunction_GET_BUILTINSto the private API (p…
55e0336
…ythonGH-135938)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@ZeroIntensity@Pranjal095
pythongh-135755: MovePyFunction_GET_BUILTINSto the private API (p…
318bef6
…ythonGH-135938)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@ZeroIntensity@taegyunkim
pythongh-135755: MovePyFunction_GET_BUILTINSto the private API (p…
2bcd352
…ythonGH-135938)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@ZeroIntensity@Agent-Hellboy
pythongh-135755: MovePyFunction_GET_BUILTINSto the private API (p…
c25034d
…ythonGH-135938)
@ZeroIntensity
ZeroIntensity deleted the private-get-builtins branch November 11, 2025 00:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou approved these changes
@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

Assignees

No one assigned

Labels

skip newstopic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZeroIntensity@encukou@ericsnowcurrently