Uh oh!
There was an error while loading. Please reload this page.
gh-133644: Remove PySys_SetArgv* for 3.15 - #136277
Conversation
PySys_SetArgv* for 3.15PySys_SetArgv* for 3.15| [function.PySys_SetArgv] | ||
| added = '3.2' | ||
| [function.PySys_SetArgvEx] | ||
| added = '3.2' |
There was a problem hiding this comment.
We shouldn't remove the entry here, we should just mark them as abi_only = true.
There was a problem hiding this comment.
Which will preserve them in python3dll.c, which is the actual breaking change (or at least the one that can be easily seen in a source diff).
Arguably they should stay in the header files as well, possibly only when Py_LIMITED_API is set. The functionality can change if it needs to, though ideally wouldn't break every existing user.
Uh oh!
There was an error while loading. Please reload this page.
picnixz
commented
Jul 4, 2025
Please check if there are projects in the wild that use this. See for instance the case of PyWeakRef_GetObject where we delayed the removal for now until less projects are using it. And also, we should coordinate with the compat project. Finally, add a section for this removal in What's New as well as possible fallbacks. |
I have some rough and preliminary search in GitHub and find some projects like:
still use these C functions. I can have a more detail exploration for popular PyPI packages later. |
xuantengh
commented
Jul 8, 2025
Well cython is a major project that we don't want to break. orjson is, iirc, simd-accelerated JSON so we don't want to break it either. They should first upgrade their code and then we'll remove the functions on our side I think. |
This PR is stale because it has been open for 30 days with no activity. |
Remove
PySys_SetArgvandPySys_SetArgvEx.📚 Documentation preview 📚: https://cpython-previews--136277.org.readthedocs.build/