bpo-37094: Add example for TestCase.skipTest in unittest doc by MakDon · Pull Request #13645 · python/cpython

MakDon · 2019-05-29T04:08:17Z

Also includes other minor test skipping doc improvements.

https://bugs.python.org/issue37094

csabella · 2019-05-29T10:27:37Z

Hi @MakDon, please create a bug tracker issue for this and link the bpo number in the title. Thanks!

MakDon · 2019-05-29T10:51:21Z

Hi @csabella , according to Python Developer’s Guide, Trivial issues (e.g. typo fixes) do not require any issue to be created.

It's just a document updating, so maybe it is not important enough to create an issue on issues tracker.

Thank you for your reply! :D

csabella · 2019-05-29T13:59:13Z

Yes, it's not obvious what trivial means, but it's really just a pull request with only a few typo fixes. Adding an additional example is more than trivial. Also, some core devs primary way of discovering issues is through the bug tracker, so adding a PR without a bug tracker link increases that likelihood of a change not being reviewed. It's usually better to have a bpo number than to not have one. 🙂

MakDon · 2019-05-30T01:54:27Z

@csabella Maybe you are right. I created an issue on issue tracker. Thanks.

zware

Needs a little bit of cleanup, but I think this will end up as a nice improvement!

zware · 2019-05-31T04:36:09Z

 # windows specific testing code
 pass

+ def test_skip_me(self):


If you take my second suggestion for the body of this example method, it could use a better name ("test_maybe_skipped" or similar, perhaps).

bedevere-bot · 2019-05-31T04:42:13Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-Authored-By: Zachary Ware <zachary.ware@gmail.com>

MakDon · 2019-05-31T04:57:01Z

@zware Thanks for your suggestions.
The document is still WIP.Please wait for a minute.
Thank your again!

@zware

Update unittest according @zware's suggestions.

MakDon · 2019-05-31T05:06:01Z

I have made the requested changes; please review again.

bedevere-bot · 2019-05-31T05:06:05Z

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.

zware

LGTM

MakDon · 2019-05-31T16:01:51Z

Cause Python 3.8.0b1 branch cut-off date moved to Monday, could i see this document update in 3.8? :D

zware · 2019-05-31T16:16:27Z

There is no restriction on documentation improvements; this will apply to 3.7 and beyond :)

miss-islington · 2019-05-31T16:19:15Z

Thanks @MakDon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

…H-13645) Also includes other minor test skipping doc improvements. https://bugs.python.org/issue37094 (cherry picked from commit ffed76b) Co-authored-by: Makdon <makdon@makdon.me>

bedevere-bot · 2019-05-31T16:19:35Z

GH-13701 is a backport of this pull request to the 3.7 branch.

Also includes other minor test skipping doc improvements. https://bugs.python.org/issue37094 (cherry picked from commit ffed76b) Co-authored-by: Makdon <makdon@makdon.me>

…H-13645) Also includes other minor test skipping doc improvements. https://bugs.python.org/issue37094

Add example for TestCase.skipTest in unittest doc
bedbc1b

bedevere-bot added the docs Documentation in the Doc dir label May 29, 2019

the-knights-who-say-ni added the CLA signed label May 29, 2019

bedevere-bot added the awaiting review label May 29, 2019

auvipy approved these changes May 29, 2019
View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels May 29, 2019

MakDon added 2 commits May 29, 2019 18:02

update output example
8116824

Update unittest.rst
6164b9a

MakDon changed the title ~~Add example for TestCase.skipTest in unittest doc~~bpo-37094: Add example for TestCase.skipTest in unittest docMay 30, 2019

csabella requested a review from zware May 31, 2019 00:49

zware requested changes May 31, 2019
View reviewed changes

bedevere-bot removed the awaiting core review label May 31, 2019

bedevere-bot added the awaiting changes label May 31, 2019

zware added the skip news label May 31, 2019

Apply suggestions from code review
88bd144
Co-Authored-By: Zachary Ware <zachary.ware@gmail.com>

Update unittest.rst
4aeb772
Update unittest according @zware's suggestions.

bedevere-bot added awaiting change review and removed awaiting changes labels May 31, 2019

zware approved these changes May 31, 2019
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 31, 2019

zware added the needs backport to 3.7 label May 31, 2019

zware added the 🤖 automerge label May 31, 2019

miss-islington merged commit ffed76b into python:masterMay 31, 2019

bedevere-bot removed the awaiting merge label May 31, 2019

bedevere-bot removed the needs backport to 3.7 label May 31, 2019

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-37094: Add example for TestCase.skipTest in unittest doc (pythonG…
b8b121f
…H-13645) Also includes other minor test skipping doc improvements. https://bugs.python.org/issue37094

Uh oh!

Uh oh!

Conversation

MakDon commented May 29, 2019• edited by zware Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

csabella commented May 29, 2019

Uh oh!

MakDon commented May 29, 2019

Uh oh!

csabella commented May 29, 2019

Uh oh!

MakDon commented May 30, 2019

Uh oh!

zware left a comment

Choose a reason for hiding this comment

Uh oh!

zwareMay 31, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented May 31, 2019

Uh oh!

MakDon commented May 31, 2019

Uh oh!

MakDon commented May 31, 2019

Uh oh!

bedevere-bot commented May 31, 2019

Uh oh!

zware left a comment

Choose a reason for hiding this comment

Uh oh!

MakDon commented May 31, 2019

Uh oh!

zware commented May 31, 2019

Uh oh!

miss-islington commented May 31, 2019

Uh oh!

bedevere-bot commented May 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MakDon commented May 29, 2019•
edited by zware
Loading