Skip to content

gh-136438: Make sure test_builtins pass with all optimization levels - #136474

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-136438-builtins
Jul 10, 2025
Merged

gh-136438: Make sure test_builtins pass with all optimization levels#136474
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-136438-builtins

Conversation

@sobolevn

@sobolevnsobolevn commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Now tests pass with all combinations of -OO and --without-doc-strings.

Before:

======================================================================
FAIL: test_compile (test.test_builtin.BuiltinTest.test_compile) (optval=0)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_builtin.py", line 445, in test_compile
self.assertEqual(rv, tuple(expected))
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
AssertionError: Tuples differ: (True, None, True, True) != (True, 'doc', True, True)
First differing element 1:
None
'doc'
- (True, None, True, True)
? ^ ^^
+ (True, 'doc', True, True)
? ^^ ^^
======================================================================
FAIL: test_compile (test.test_builtin.BuiltinTest.test_compile) (optval=1)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_builtin.py", line 445, in test_compile
self.assertEqual(rv, tuple(expected))
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
AssertionError: Tuples differ: (False, None, False, False) != (False, 'doc', False, False)
First differing element 1:
None
'doc'
- (False, None, False, False)
? ^ ^^
+ (False, 'doc', False, False)
? ^^ ^^
======================================================================
FAIL: test_compile_ast (test.test_builtin.BuiltinTest.test_compile_ast)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_builtin.py", line 627, in test_compile_ast
self.assertEqual(opt_right.value, True)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False != True
----------------------------------------------------------------------
Ran 131 tests in 0.211s

@sobolevn
sobolevn requested a review from vstinnerJuly 9, 2025 15:56
@bedevere-appbedevere-appBot mentioned this pull request Jul 9, 2025
Closed
8 tasks
@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Jul 9, 2025
@sobolevnsobolevn added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 9, 2025
blockchainGuru1018
blockchainGuru1018 approved these changes Jul 9, 2025
View reviewed changes

@blockchainGuru1018blockchainGuru1018 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobolevn, reviewed and approved this PR

vstinner
vstinner approved these changes Jul 10, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn
sobolevn merged commit c176543 into python:mainJul 10, 2025
53 checks passed
@miss-islington-app

miss-islington-appBot commented Jul 10, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@sobolevn

sobolevn commented Jul 10, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks everyone!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2025
@sobolevn@miss-islington
pythongh-136438: Make suretest_builtinspass with all optimization…
097755c
… levels (pythonGH-136474)
(cherry picked from commit c176543)
Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app

miss-islington-appBot commented Jul 10, 2025

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c17654334946b232aa296696cf70ec93a09d8156 3.13

@bedevere-app

bedevere-appBot commented Jul 10, 2025

Copy link
Copy Markdown

GH-136496 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jul 10, 2025
sobolevn added a commit that referenced this pull request Jul 10, 2025
@miss-islington@sobolevn
[3.14]gh-136438: Make suretest_builtinspass with all optimizatio…
2de82bc
…n levels (GH-136474) (#136496)
gh-136438: Make sure `test_builtins` pass with all optimization levels (GH-136474)
(cherry picked from commit c176543)
Co-authored-by: sobolevn <mail@sobolevn.me>
@sobolevn

sobolevn commented Jul 10, 2025

Copy link
Copy Markdown
MemberAuthor

Looking at 3.13 backport.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jul 10, 2025
@sobolevn
[3.13]pythongh-136438: Make suretest_builtinspass with all optim…
4487228
…ization levels (pythonGH-136474)
(cherry picked from commit c176543)
Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented Jul 10, 2025

Copy link
Copy Markdown

GH-136502 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 10, 2025
sobolevn added a commit that referenced this pull request Jul 10, 2025
@sobolevn
[3.13]gh-136438: Make suretest_builtinspass with all optimizatio…
a2140fa
…n levels (GH-136474) (#136502)
(cherry picked from commit c176543)
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@sobolevn@AndPuQing
pythongh-136438: Make suretest_builtinspass with all optimization…
74291d2
… levels (python#136474)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn@Pranjal095
pythongh-136438: Make suretest_builtinspass with all optimization…
5eef776
… levels (python#136474)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@sobolevn@picnixz
pythongh-136438: Make suretest_builtinspass with all optimization…
912cdae
… levels (python#136474)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@sobolevn@taegyunkim
pythongh-136438: Make suretest_builtinspass with all optimization…
86eea3b
… levels (python#136474)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@sobolevn@Agent-Hellboy
pythongh-136438: Make suretest_builtinspass with all optimization…
065c7bf
… levels (python#136474)
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington@sobolevn@kumaraditya303
[3.14]pythongh-136438: Make suretest_builtinspass with all optim…
b0c33fe
…ization levels (pythonGH-136474) (python#136496)
pythongh-136438: Make sure `test_builtins` pass with all optimization levels (pythonGH-136474)
(cherry picked from commit c176543)
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
+2 more reviewers
@blockchainGuru1018blockchainGuru1018blockchainGuru1018 approved these changes
@LamentXU123LamentXU123LamentXU123 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sobolevnsobolevn

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@vstinner@blockchainGuru1018@LamentXU123