Uh oh!
There was an error while loading. Please reload this page.
gh-136549: Fix signature of threading.excepthook() - #136559
Merged
serhiy-storchaka merged 2 commits intoJul 12, 2025
Merged
Conversation
ZeroIntensity
commented
Jul 12, 2025
Member
Is there any reason this wasn't caught by regrtest? |
serhiy-storchaka
commented
Jul 12, 2025
MemberAuthor
Regrtest sets different |
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
Ok, thanks. The core change looks good to me. Could we add a simple test for this? Something like inspect.signature(threading.__excepthook__) should work.
Uh oh!
There was an error while loading. Please reload this page.
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 12, 2025
GH-136589 is a backport of this pull request to the 3.14 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 12, 2025
GH-136590 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka added a commit
that referenced
this pull request
Jul 12, 2025
…GH-136590) (cherry picked from commit be2c3d2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit
that referenced
this pull request
Jul 12, 2025
…GH-136589) (cherry picked from commit be2c3d2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
picnixz pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
taegyunkim pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
kumaraditya303 pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…onGH-136559) (pythonGH-136589) (cherry picked from commit be2c3d2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_inspectlocally #136549