Skip to content

gh-136438: Make sure test_ast pass with all optimization levels - #136596

Merged
Eclips4 merged 3 commits into
python:mainfrom
efimov-mikhail:issue-136438-test_ast
Jul 18, 2025
Merged

gh-136438: Make sure test_ast pass with all optimization levels#136596
Eclips4 merged 3 commits into
python:mainfrom
efimov-mikhail:issue-136438-test_ast

Conversation

@efimov-mikhail

@efimov-mikhailefimov-mikhail commented Jul 12, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Now tests pass with all combinations of -OO and --without-doc-strings.
It was long lists of errors before, but all proposed fixes are just to add some needed optimize=False options.

@bedevere-appbedevere-appBot mentioned this pull request Jul 12, 2025
Closed
8 tasks
@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Jul 12, 2025
Eclips4
Eclips4 reviewed Jul 17, 2025
View reviewed changes
Comment threadLib/test/test_ast/test_ast.py Outdated
@Eclips4

Eclips4 commented Jul 17, 2025

Copy link
Copy Markdown
Member

I believe the explanation is as follows:
If the optimize parameter isn’t passed explicitly, the interpreter uses its internal setting (which can be modified using the -O or -OO flags).
Am I right, @efimov-mikhail?

@efimov-mikhail@Eclips4
Update Lib/test/test_ast/test_ast.py
3d75f06
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@efimov-mikhail

efimov-mikhail commented Jul 17, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

If the optimize parameter isn’t passed explicitly, the interpreter uses its internal setting (which can be modified using the -O or -OO flags).

Exactly. I've added checks only in those tests that fail with -OO. We now force to run ast.parse and compile without optimizations to be sure that their results don't depend on runtime flags.

@Eclips4
Eclips4 merged commit 03017a8 into python:mainJul 18, 2025
40 checks passed
@Eclips4

Eclips4 commented Jul 18, 2025

Copy link
Copy Markdown
Member

Thank you @efimov-mikhail!

@efimov-mikhail

efimov-mikhail commented Jul 18, 2025

Copy link
Copy Markdown
MemberAuthor

Thx for merge, @Eclips4 !

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@efimov-mikhail@taegyunkim
pythongh-136438: Make suretest_astpass with all optimization leve…
880ce75
…ls (python#136596)
Explicitly pass an `optimizer` parameter to the calls of `ast.parse/compile`, because if it is not provided, the interpreter will use its internal state, which can be modified using the `-O` or `-OO` flags.
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@efimov-mikhail@Agent-Hellboy
pythongh-136438: Make suretest_astpass with all optimization leve…
35884f2
…ls (python#136596)
Explicitly pass an `optimizer` parameter to the calls of `ast.parse/compile`, because if it is not provided, the interpreter will use its internal state, which can be modified using the `-O` or `-OO` flags.
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4Eclips4Eclips4 left review comments
@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner
@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efimov-mikhail@Eclips4@brianschubert