Uh oh!
There was an error while loading. Please reload this page.
gh-127146: Emscripten: more regular stack overflow skips - #136708
Merged
freakboy3742 merged 2 commits intoJul 16, 2025
Conversation
…ad of ad hoc skip In two places. Also, make the skip_emscripten_stack_overflow message match wasi's message.
hoodmane
commented
Jul 16, 2025
ContributorAuthor
!buildbot Emscripten |
bedevere-bot
commented
Jul 16, 2025
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 8642a6c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136708%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742
enabled auto-merge (squash)
July 16, 2025 13:43
Uh oh!
There was an error while loading. Please reload this page.
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2025
…nGH-136708) Makes the Emscripten stack overflow skip message consistent with WASI, and replaces some ad-hoc skips. (cherry picked from commit c730952) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
GH-136712 is a backport of this pull request to the 3.14 branch. |
freakboy3742 pushed a commit
that referenced
this pull request
Jul 16, 2025
taegyunkim pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…n#136708) Makes the Emscripten stack overflow skip message consistent with WASI, and replaces some ad-hoc skips.
Agent-Hellboy pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…n#136708) Makes the Emscripten stack overflow skip message consistent with WASI, and replaces some ad-hoc skips.
kumaraditya303 pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…pythonGH-136708) (python#136712) Makes the Emscripten stack overflow skip message consistent with WASI, and replaces some ad-hoc skips. (cherry picked from commit c730952) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In two places use skip_emscripten_stack_overflow instead of skipIf with an ad-hoc message. Also, make the skip_emscripten_stack_overflow message match wasi's message.